Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751822AbdGaIKn (ORCPT <rfc822;w@1wt.eu>);
        Mon, 31 Jul 2017 04:10:43 -0400
Received: from mail-qt0-f181.google.com ([209.85.216.181]:38586 "EHLO
        mail-qt0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750979AbdGaIKl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 31 Jul 2017 04:10:41 -0400
MIME-Version: 1.0
In-Reply-To: <1501403839-8876-5-git-send-email-arvind.yadav.cs@gmail.com>
References: <1501403839-8876-1-git-send-email-arvind.yadav.cs@gmail.com> <1501403839-8876-5-git-send-email-arvind.yadav.cs@gmail.com>
From: Jinpu Wang <jinpu.wang@profitbricks.com>
Date: Mon, 31 Jul 2017 10:10:20 +0200
Message-ID: <CAMGffEkq7w5C=cWg=FhwoZMO5SAmMtBW7sT_5GVbPpjQhaCegg@mail.gmail.com>
Subject: Re: [PATCH 04/29] scsi: pm8001: constify pci_device_id.
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
        "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>, mdr@sgi.com,
        Hannes Reinecke <hare@suse.com>, aacraid@adaptec.com, matthew@wil.cx,
        fthain@telegraphics.com.au, schmitzmic@gmail.com,
        kashyap.desai@broadcom.com, sumit.saxena@broadcom.com,
        gotom@debian.or.jp, mrochs@linux.vnet.ibm.com,
        yokota@netlab.is.tsukuba.ac.jp, QLogic-Storage-Upstream@cavium.com,
        Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1226
Lines: 34

On Sun, Jul 30, 2017 at 10:37 AM, Arvind Yadav
<arvind.yadav.cs@gmail.com> wrote:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/scsi/pm8001/pm8001_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
> index 034b2f7..f2757cc 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -1270,7 +1270,7 @@ static int pm8001_pci_resume(struct pci_dev *pdev)
>  /* update of pci device, vendor id and driver data with
>   * unique value for each of the controller
>   */
> -static struct pci_device_id pm8001_pci_table[] = {
> +static const struct pci_device_id pm8001_pci_table[] = {
>         { PCI_VDEVICE(PMC_Sierra, 0x8001), chip_8001 },
>         { PCI_VDEVICE(PMC_Sierra, 0x8006), chip_8006 },
>         { PCI_VDEVICE(ADAPTEC2, 0x8006), chip_8006 },
> --
> 2.7.4
>

Thanks,
Acked-by: Jack Wang <jinpu.wang@profitbricks.com>

-- 
Jack Wang
Linux Kernel Developer