Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751860AbdGaIqY (ORCPT ); Mon, 31 Jul 2017 04:46:24 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:20846 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbdGaIqX (ORCPT ); Mon, 31 Jul 2017 04:46:23 -0400 Date: Mon, 31 Jul 2017 11:45:19 +0300 From: Dan Carpenter To: janani-sankarababu Cc: eric@anholt.net, stefan.wahren@i2se.com, devel@driverdev.osuosl.org, f.fainelli@gmail.com, sbranden@broadcom.com, gregkh@linuxfoundation.org, vicmos89@gmail.com, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr, mzoran@crowfest.net, sreyamittal5@gmail.com, rjui@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH] Staging: vc04_services: Fix WARN_ON instead of BUG_ON Message-ID: <20170731084519.s7zy3cvejtvcqbf2@mwanda> References: <1501485243-11977-1-git-send-email-jananis37@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501485243-11977-1-git-send-email-jananis37@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1099 Lines: 27 On Mon, Jul 31, 2017 at 12:44:03PM +0530, janani-sankarababu wrote: > This patch is to replace the use of BUG_ON macro with WARN_ON > inorder to prevent the crashing of the kernel. > > Signed-off-by: Janani Sankara Babu > --- > drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > index f484bb0..30bc246 100644 > --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c > @@ -91,7 +91,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol *kcontrol, > if (mutex_lock_interruptible(&chip->audio_mutex)) ^^^^^^ We dereference chip here. > return -EINTR; > > - BUG_ON(!chip && !(chip->avail_substreams & AVAIL_SUBSTREAMS_MASK)); > + WARN_ON(!chip && !(chip->avail_substreams & AVAIL_SUBSTREAMS_MASK)); ^^^^^ Too late. regards, dan carpenter