Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751833AbdGaJbg (ORCPT ); Mon, 31 Jul 2017 05:31:36 -0400 Received: from lb2-smtp-cloud9.xs4all.net ([194.109.24.26]:40092 "EHLO lb2-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbdGaJbf (ORCPT ); Mon, 31 Jul 2017 05:31:35 -0400 Subject: Re: [PATCH v3] go2001 hardware codec support To: Thierry Escande , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <1501004422-8294-1-git-send-email-thierry.escande@collabora.com> From: Hans Verkuil Message-ID: <1c4e62c4-75dd-1da2-e101-6ae254b9fb65@xs4all.nl> Date: Mon, 31 Jul 2017 11:31:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1501004422-8294-1-git-send-email-thierry.escande@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfCUbMsG1t+nBKXitkQweYF2y2JHvy+EkC3gU6zrIzok25P7iSxuJeH6TndF94PeDKjocE67O1jZMmoPKvB/gEUlQdmAXHIi3cg0OkHZoYEixW77hoWeZ zRo0oamaAAcyClD5k3ynAuvGe45iOflKKyyKIITGIAnIe12lI7KYXZbheJ1v7F8xjOktKjdZXDbYVYkj3dDbv4ScCSlEZYw5LvDMsb0tBo+g64P/VAnZ6xdZ S0LX9ge2DDsYXBTViNQzUNIE7o1fm42nAFLlBj7rhRFIcv5u+izgMdcjDqCsMmiXnv6KDbOeovwpe/8VKAvQPg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 8455 Lines: 241 On 07/25/2017 07:40 PM, Thierry Escande wrote: > Hi, > > This patch introduces the go2001 hardware codec driver. > > Changes in v3: > - Replace crop iotcl with selection ones > - Use video dev device_caps field > - Return v4l2_ctrl_subscribe_event() for default case > - Fix start_streaming error handling > - Remove empty ctrl ops callbacks > - Avoid use of private ctrl structures > - Remove VB2_USERPTR support > - Remove format description strings > > Changes in v2: > - Remove unneeded call to dma_cache_sync() on coherent dma buffer. > > Following are the results of v4l2-compliance utility execution for both > /dev/video0 and /dev/video1 devices. > > Note that the failing tests are due to un-initialized internal > structures of the driver not done through these unit tests. Please explain. This should not happen. Regards, Hans > > $ ./utils/v4l2-compliance/v4l2-compliance -d /dev/video0 > v4l2-compliance SHA : 1ae9a7adea3766879935dfede90d5aefd954c786 > > Driver Info: > Driver name : go2001 > Card type : GO2001 PCIe codec > Bus info : PCI:0000:03:00.0 > Driver version: 4.12.0 > Capabilities : 0x84204000 > Video Memory-to-Memory Multiplanar > Streaming > Extended Pix Format > Device Capabilities > Device Caps : 0x04204000 > Video Memory-to-Memory Multiplanar > Streaming > Extended Pix Format > > Compliance test for device /dev/video0 (not using libv4l2): > > Required ioctls: > test VIDIOC_QUERYCAP: OK > > Allow for multiple opens: > test second video open: OK > test VIDIOC_QUERYCAP: OK > test VIDIOC_G/S_PRIORITY: OK > test for unlimited opens: OK > > Debug ioctls: > test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) > test VIDIOC_LOG_STATUS: OK (Not Supported) > > Input ioctls: > test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) > test VIDIOC_G/S_FREQUENCY: OK (Not Supported) > test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) > test VIDIOC_ENUMAUDIO: OK (Not Supported) > test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) > test VIDIOC_G/S_AUDIO: OK (Not Supported) > Inputs: 0 Audio Inputs: 0 Tuners: 0 > > Output ioctls: > test VIDIOC_G/S_MODULATOR: OK (Not Supported) > test VIDIOC_G/S_FREQUENCY: OK (Not Supported) > test VIDIOC_ENUMAUDOUT: OK (Not Supported) > test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) > test VIDIOC_G/S_AUDOUT: OK (Not Supported) > Outputs: 0 Audio Outputs: 0 Modulators: 0 > > Input/Output configuration ioctls: > test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) > test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) > test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) > test VIDIOC_G/S_EDID: OK (Not Supported) > > Control ioctls: > test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK > test VIDIOC_QUERYCTRL: OK > test VIDIOC_G/S_CTRL: OK > test VIDIOC_G/S/TRY_EXT_CTRLS: OK > test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK > test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) > Standard Controls: 2 Private Controls: 0 > > Format ioctls: > test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK > test VIDIOC_G/S_PARM: OK (Not Supported) > test VIDIOC_G_FBUF: OK (Not Supported) > fail: v4l2-test-formats.cpp(590): Video Capture Multiplanar cap set, but no Video Capture Multiplanar formats defined > test VIDIOC_G_FMT: FAIL > test VIDIOC_TRY_FMT: OK (Not Supported) > test VIDIOC_S_FMT: OK (Not Supported) > test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) > test Cropping: OK (Not Supported) > test Composing: OK (Not Supported) > fail: v4l2-test-formats.cpp(1670): doioctl(node, VIDIOC_G_FMT, &fmt) > test Scaling: FAIL > > Codec ioctls: > test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) > test VIDIOC_G_ENC_INDEX: OK (Not Supported) > test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) > > Buffer ioctls: > test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK > fail: v4l2-test-buffers.cpp(574): VIDIOC_EXPBUF is supported, but the V4L2_MEMORY_MMAP support is missing, probably due to earlier failing format tests. > test VIDIOC_EXPBUF: OK (Not Supported) > > Test input 0: > > Total: 43, Succeeded: 41, Failed: 2, Warnings: 0 > > $ ./utils/v4l2-compliance/v4l2-compliance -d /dev/video1 > v4l2-compliance SHA : 1ae9a7adea3766879935dfede90d5aefd954c786 > > Driver Info: > Driver name : go2001 > Card type : GO2001 PCIe codec > Bus info : PCI:0000:03:00.0 > Driver version: 4.12.0 > Capabilities : 0x84204000 > Video Memory-to-Memory Multiplanar > Streaming > Extended Pix Format > Device Capabilities > Device Caps : 0x04204000 > Video Memory-to-Memory Multiplanar > Streaming > Extended Pix Format > > Compliance test for device /dev/video1 (not using libv4l2): > > Required ioctls: > test VIDIOC_QUERYCAP: OK > > Allow for multiple opens: > test second video open: OK > test VIDIOC_QUERYCAP: OK > test VIDIOC_G/S_PRIORITY: OK > test for unlimited opens: OK > > Debug ioctls: > test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) > test VIDIOC_LOG_STATUS: OK (Not Supported) > > Input ioctls: > test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) > test VIDIOC_G/S_FREQUENCY: OK (Not Supported) > test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) > test VIDIOC_ENUMAUDIO: OK (Not Supported) > test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) > test VIDIOC_G/S_AUDIO: OK (Not Supported) > Inputs: 0 Audio Inputs: 0 Tuners: 0 > > Output ioctls: > test VIDIOC_G/S_MODULATOR: OK (Not Supported) > test VIDIOC_G/S_FREQUENCY: OK (Not Supported) > test VIDIOC_ENUMAUDOUT: OK (Not Supported) > test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) > test VIDIOC_G/S_AUDOUT: OK (Not Supported) > Outputs: 0 Audio Outputs: 0 Modulators: 0 > > Input/Output configuration ioctls: > test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) > test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) > test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) > test VIDIOC_G/S_EDID: OK (Not Supported) > > Control ioctls: > test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK > test VIDIOC_QUERYCTRL: OK > test VIDIOC_G/S_CTRL: OK > test VIDIOC_G/S/TRY_EXT_CTRLS: OK > test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK > test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) > Standard Controls: 4 Private Controls: 0 > > Format ioctls: > test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK > fail: v4l2-test-formats.cpp(1213): got error 22 when setting parms for buftype 10 > test VIDIOC_G/S_PARM: FAIL > test VIDIOC_G_FBUF: OK (Not Supported) > fail: v4l2-test-formats.cpp(446): !pix_mp.width || !pix_mp.height > test VIDIOC_G_FMT: FAIL > test VIDIOC_TRY_FMT: OK (Not Supported) > test VIDIOC_S_FMT: OK (Not Supported) > test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) > test Cropping: OK (Not Supported) > test Composing: OK (Not Supported) > fail: v4l2-test-formats.cpp(1678): doioctl(node, VIDIOC_G_FMT, &fmt) > test Scaling: FAIL > > Codec ioctls: > test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) > test VIDIOC_G_ENC_INDEX: OK (Not Supported) > test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) > > Buffer ioctls: > test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK > fail: v4l2-test-buffers.cpp(574): VIDIOC_EXPBUF is supported, but the V4L2_MEMORY_MMAP support is missing, probably due to earlier failing format tests. > test VIDIOC_EXPBUF: OK (Not Supported) > > Test input 0: > > > Total: 43, Succeeded: 40, Failed: 3, Warnings: 0 > > > Thierry Escande (1): > [media] v4l2: Add support for go2001 PCI codec driver > > drivers/media/pci/Kconfig | 2 + > drivers/media/pci/Makefile | 1 + > drivers/media/pci/go2001/Kconfig | 11 + > drivers/media/pci/go2001/Makefile | 2 + > drivers/media/pci/go2001/go2001.h | 331 ++++ > drivers/media/pci/go2001/go2001_driver.c | 2525 ++++++++++++++++++++++++++++++ > drivers/media/pci/go2001/go2001_hw.c | 1362 ++++++++++++++++ > drivers/media/pci/go2001/go2001_hw.h | 55 + > drivers/media/pci/go2001/go2001_proto.h | 359 +++++ > 9 files changed, 4648 insertions(+) > create mode 100644 drivers/media/pci/go2001/Kconfig > create mode 100644 drivers/media/pci/go2001/Makefile > create mode 100644 drivers/media/pci/go2001/go2001.h > create mode 100644 drivers/media/pci/go2001/go2001_driver.c > create mode 100644 drivers/media/pci/go2001/go2001_hw.c > create mode 100644 drivers/media/pci/go2001/go2001_hw.h > create mode 100644 drivers/media/pci/go2001/go2001_proto.h >