Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752181AbdGaKTo (ORCPT ); Mon, 31 Jul 2017 06:19:44 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:48872 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbdGaKTm (ORCPT ); Mon, 31 Jul 2017 06:19:42 -0400 Subject: Re: [PATCH] psci: add CPU_IDLE dependency To: Arnd Bergmann Cc: Lorenzo Pieralisi , Olof Johansson , Tero Kristo , Thierry Reding , Carlo Caione , Nishanth Menon , Jean Delvare , linux-kernel@vger.kernel.org References: <20170731085523.320244-1-arnd@arndb.de> From: Kevin Brodsky Message-ID: Date: Mon, 31 Jul 2017 11:19:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170731085523.320244-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1502 Lines: 41 [Apologies for the resending, damn Thunderbird sending HTML...] On 31/07/17 09:55, Arnd Bergmann wrote: > I ran into a build error for the psci_checker: > > drivers/firmware/psci_checker.o: In function `psci_checker': > psci_checker.c:(.init.text+0x528): undefined reference to `cpuidle_devices' > > As far as I can tell, this is simply a very rare combination of options, > but the problem has existed since the code was initially added. > Adding a Kconfig dependency makes it build properly. Good catch! For some reason I missed this config option when figuring out the dependencies... I wonder though, shouldn't cpuidle.h declare cpuidle_devices conditionally on CONFIG_CPU_IDLE? > Fixes: ea8b1c4a6019 ("drivers: psci: PSCI checker module") > Signed-off-by: Arnd Bergmann Acked-by: Kevin Brodsky Cheers, Kevin > --- > drivers/firmware/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index 6e4ed5a9c6fd..1983e6e0106f 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -10,7 +10,7 @@ config ARM_PSCI_FW > > config ARM_PSCI_CHECKER > bool "ARM PSCI checker" > - depends on ARM_PSCI_FW && HOTPLUG_CPU && !TORTURE_TEST > + depends on ARM_PSCI_FW && HOTPLUG_CPU && CPU_IDLE && !TORTURE_TEST > help > Run the PSCI checker during startup. This checks that hotplug and > suspend operations work correctly when using PSCI.