Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752139AbdGaKWP (ORCPT ); Mon, 31 Jul 2017 06:22:15 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35108 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751825AbdGaKWN (ORCPT ); Mon, 31 Jul 2017 06:22:13 -0400 From: RishabhHardas To: gregkh@linuxfoundation.org Cc: linux@Wolf-Entwicklungen.de, colin.king@canonical.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, RishabhHardas Subject: [PATCH] staging/pi433: Solved some coding style issues in pi433_if.c Date: Mon, 31 Jul 2017 15:51:13 +0530 Message-Id: <1501496473-11499-1-git-send-email-rishabheudyptula@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1750 Lines: 59 From: RishabhHardas Solved a few coding style issues, used BIT macro to set MINORBITS. Signed-off-by: RishabhHardas --- drivers/staging/pi433/pi433_if.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index d9328ce..f10ffc3 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -47,18 +47,18 @@ #include #include #include +#include #ifdef CONFIG_COMPAT -#include +#include #endif #include "pi433_if.h" #include "rf69.h" - -#define N_PI433_MINORS (1U << MINORBITS) /*32*/ /* ... up to 256 */ -#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */ -#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */ -#define NUM_DIO 2 +#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */ +#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */ +#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */ +#define NUM_DIO 2 static dev_t pi433_dev; static DEFINE_IDR(pi433_idr); @@ -66,10 +66,14 @@ static struct class *pi433_class; /* mainly for udev to create /dev/pi433 */ -/* tx config is instance specific - so with each open a new tx config struct is needed */ -/* rx config is device specific - so we have just one rx config, ebedded in device struct */ +/* + * tx config is instance specific + * so with each open a new tx config struct is needed + */ +/* + * rx config is device specific + * so we have just one rx config, ebedded in device struct + */ struct pi433_device { /* device handling related values */ dev_t devt; -- 1.9.1