Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751631AbdGaKZG (ORCPT ); Mon, 31 Jul 2017 06:25:06 -0400 Received: from ozlabs.org ([103.22.144.67]:43099 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750847AbdGaKZF (ORCPT ); Mon, 31 Jul 2017 06:25:05 -0400 From: Michael Ellerman To: SZ Lin , ashleydlai@gmail.com Cc: benh@kernel.crashing.org, paulus@samba.org, peterhuewe@gmx.de, tpmdd@selhorst.ne, jarkko.sakkinen@linux.intel.com, jgunthorpe@obsidianresearch.com, tpmdd-devel@lists.sourceforge.net, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, SZ Lin Subject: Re: [PATCH 2/5] Fix "ERROR: code indent should use tabs where possible" In-Reply-To: <20170729072433.13194-3-sz.lin@moxa.com> References: <20170729072433.13194-1-sz.lin@moxa.com> <20170729072433.13194-3-sz.lin@moxa.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Mon, 31 Jul 2017 20:25:03 +1000 Message-ID: <87bmo06gzk.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 855 Lines: 25 SZ Lin writes: > ERROR: code indent should use tabs where possible > +^I^I "Need to wait for TPM to finish\n");$ > > Signed-off-by: SZ Lin > --- > drivers/char/tpm/tpm_ibmvtpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c > index f01d083eced2..23913fc86158 100644 > --- a/drivers/char/tpm/tpm_ibmvtpm.c > +++ b/drivers/char/tpm/tpm_ibmvtpm.c > @@ -127,7 +127,7 @@ static int tpm_ibmvtpm_send(struct tpm_chip *chip, u8 *buf, size_t count) > > if (ibmvtpm->tpm_processing_cmd) { > dev_info(ibmvtpm->dev, > - "Need to wait for TPM to finish\n"); > + "Need to wait for TPM to finish\n"); There's no reason for that to be on a separate line at all. Just make it a single line dev_info( ... ); cheers