Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752084AbdGaLoY (ORCPT ); Mon, 31 Jul 2017 07:44:24 -0400 Received: from smtp-out6.electric.net ([192.162.217.182]:50994 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751735AbdGaLoV (ORCPT ); Mon, 31 Jul 2017 07:44:21 -0400 From: David Laight To: "'Florian Fainelli'" , Vivien Didelot , Egil Hjelmeland , "andrew@lunn.ch" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" Subject: RE: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Thread-Topic: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Thread-Index: AQHTB8OwO4fnTRgDQkOMO1lE2MBY/6Jt0XFA Date: Mon, 31 Jul 2017 11:44:15 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD0047300@AcuExch.aculab.com> References: <20170728151157.28983-1-privat@egil-hjelmeland.no> <20170728151157.28983-5-privat@egil-hjelmeland.no> <87fudglget.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> <50d2d34c-c1a5-7f0a-90f1-44b1be1775b7@egil-hjelmeland.no> <87fudgqz4w.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> <1250382a-1c17-8e82-8c5c-fe14786c84db@gmail.com> In-Reply-To: <1250382a-1c17-8e82-8c5c-fe14786c84db@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Outbound-IP: 156.67.243.126 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuExch.aculab.com X-TLS: TLSv1:AES128-SHA:128 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6VBiRCe030706 Content-Length: 732 Lines: 23 From: Florian Fainelli > Sent: 28 July 2017 18:05 ... > >>>> +EXPORT_SYMBOL(lan9303_indirect_phy_ops); > >>> > >>> Isn't EXPORT_SYMBOL_GPL prefered over EXPORT_SYMBOL? > >> > >> I have no opinion. I just used the same variant as the other EXPORTS > >> in the file. > > > > If there is no concern from others about this, LGTM too: > > Since the kernel module license is GPL, EXPORT_SYMBOL_GPL() would seem > to be appropriate, which can be done as a subsequent patch. It depends on whether the function needs to be usable by 'out of tree' non-GPL modules. This looks like a 'private' export between related modules. The problems arise with functions like put_ns() and put_pid() which can easily be needed by non-GPL code. David