Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751884AbdGaMDh (ORCPT ); Mon, 31 Jul 2017 08:03:37 -0400 Received: from ozlabs.org ([103.22.144.67]:60569 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbdGaMDg (ORCPT ); Mon, 31 Jul 2017 08:03:36 -0400 From: Michael Ellerman To: Brian King Cc: Brian J King , Jens Axboe , Bart Van Assche , "linux-block\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , "linuxppc-dev\@lists.ozlabs.org" Subject: Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage In-Reply-To: <5dcfe3ac-50c7-86a6-e571-fe5a1c1dc316@linux.vnet.ibm.com> References: <87a83qfosu.fsf@concordia.ellerman.id.au> <073ed79c-11ce-e86c-a905-91fd28675d47@kernel.dk> <1501166846.2516.1.camel@wdc.com> <5b85a365-faa1-3987-9b6b-270399c30686@kernel.dk> <87lgn9dqx3.fsf@concordia.ellerman.id.au> <92379297-9667-ae52-b05c-6c8a0ce4751c@kernel.dk> <5dcfe3ac-50c7-86a6-e571-fe5a1c1dc316@linux.vnet.ibm.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Mon, 31 Jul 2017 22:03:30 +1000 Message-ID: <87379c6cfh.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 675 Lines: 22 Brian King writes: > On 07/28/2017 10:17 AM, Brian J King wrote: >> Jens Axboe wrote on 07/28/2017 09:25:48 AM: >> >>> Can you try the below fix? Should be more palatable than the previous >>> one. Brian, maybe you can take a look at the IRQ issue mentioned above? > > Michael, > > Does this address the issue you are seeing? Yes it seems to, thanks. I only see the trace on reboot, and not 100% of the time. But I've survived a couple of reboots now without seeing anything, so I think this is helping. I'll put the patch in my Jenkins over night and let you know how it survives that, which should be ~= 25 boots. cheers