Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752419AbdGaNAL (ORCPT ); Mon, 31 Jul 2017 09:00:11 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:48003 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750987AbdGaNAJ (ORCPT ); Mon, 31 Jul 2017 09:00:09 -0400 Subject: Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900 To: Pavel Machek CC: Aaro Koskinen , Peter Ujfalusi , Tony Lindgren , , , , Laurent Pinchart References: <20170614221133.k7gmbzzjsbmbjgbc@darkstar.musicnaut.iki.fi> <20170629185013.aec7qhvrl3waifww@darkstar.musicnaut.iki.fi> <20170630085851.j5apctivufhmhp64@darkstar.musicnaut.iki.fi> <5bc9976e-228c-5cba-c2ae-bfc5135f17a0@ti.com> <20170704150902.GB10703@localhost> From: Tomi Valkeinen Message-ID: <1c44c560-a8f3-04e2-9558-1639441e3e32@ti.com> Date: Mon, 31 Jul 2017 15:59:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170704150902.GB10703@localhost> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lv8Dlu5MqJQeL2cIRFkQ1FgPRak2HQtDj" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3799 Lines: 100 --lv8Dlu5MqJQeL2cIRFkQ1FgPRak2HQtDj Content-Type: multipart/mixed; boundary="3jOwMwUT5Jo5FEVgMPx5Waer6rP2FfrqW"; protected-headers="v1" From: Tomi Valkeinen To: Pavel Machek Cc: Aaro Koskinen , Peter Ujfalusi , Tony Lindgren , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Laurent Pinchart Message-ID: <1c44c560-a8f3-04e2-9558-1639441e3e32@ti.com> Subject: Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900 References: <20170614221133.k7gmbzzjsbmbjgbc@darkstar.musicnaut.iki.fi> <20170629185013.aec7qhvrl3waifww@darkstar.musicnaut.iki.fi> <20170630085851.j5apctivufhmhp64@darkstar.musicnaut.iki.fi> <5bc9976e-228c-5cba-c2ae-bfc5135f17a0@ti.com> <20170704150902.GB10703@localhost> In-Reply-To: <20170704150902.GB10703@localhost> --3jOwMwUT5Jo5FEVgMPx5Waer6rP2FfrqW Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 04/07/17 18:09, Pavel Machek wrote: > Hi! >=20 >>>>>> Are you sure it doesn't probe? It fails the omapdss_stack_is_ready= () >>>>>> check? >>>>> >>>>> It appears the reason was that I didn't have >>>>> CONFIG_DRM_OMAP_CONNECTOR_ANALOG_TV enabled. >>>>> >>>>> I think that's wrong. I don't own an analog TV, so why should I ena= ble >>>>> such option to get device's built-in display working? >>>> >>>> Indeed. Unfortunately I don't have a solution for that. >>>> >>>> DRM doesn't support adding devices after probe. So at omapdrm probe = time >>>> we have to decide which displays to use. In the dts file, n900 defin= es >>>> the lcd and analog tv. omapdrm sees those, and, of course, must wait= >>>> until their respective drivers have probed. If you don't have the >>>> display driver enabled, it's never loaded and omapdrm never probes a= s it >>>> keeps waiting for those. >>> >>> Could you at least print some kind of message early in the boot ("oma= pdrm >>> is waiting for drivers for display x and y")? >> >> That could be quite spammy. omapdrm will defer probe if the displays a= re >> not present, and the deferred probing machinery will then cause a new >> omapdrm probe later. That can happen a lot of times before the drivers= >> are there. >=20 > Well doing printk just once should not be a problem...? I'm not sure if that would really help much... And you would practically always see the print, even when everything works fine, which would be useless and could raise false alarms. Tomi --3jOwMwUT5Jo5FEVgMPx5Waer6rP2FfrqW-- --lv8Dlu5MqJQeL2cIRFkQ1FgPRak2HQtDj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZfym/AAoJEPo9qoy8lh71ja4QAIGer74qfoFCdW52GBliFdWq jOC3mVREQOYmdHMENmIAPiGN8f/T0vEJqFdsprJes1IR7FNIb179AvV2AlCBQRSB GbEXL87O7nP3PlUB6b9bQGOjoauUEgzy0d3QEtb7DZkg+6tBKbGuCit1eiyN4e/N m18KjZrnFldMJuou4H6txILO7bTcU/odEiCQ7YhW0LMMKBpO4rew5HvH1C1cmGsU k7OVkE4UdpyBWaiY6urpr2t0MHKfAbQdsDvLkpvGckcYEKyJUdTdZcCoYlQUyqCU HHdxCRfLja86vGQvaPqNIairORwJGBEyGLvDKnD/WVNFZwGh8GVkJ2er7aovKNXi Twt3xcFBHHbdANFqpO6ZM3c72sMZbmfwDzWz6RyF5YtH3vcCmLYeVhqvzt/XV4HW l8HolqtOHAUwfHtiXx1n/kATI8ODUyO3iKgWWKo8/ecHtXCi04mPxkYzrNK9cnN8 xpC0n5ph9G+kBcV1oLilrhn/Vt9YHJkIvt3+Oy5sgpPIzXHlZXyFCRnR5KQMg1Oj bZzEe1B4rpqVfaKGgW+tC4l8xvf81FhFMSoT8YqqQXSi1X3xd7R57AXR851SfDKZ BzadUtJe+EtlRJfmCeEAjl6rD/bL3p+fbScmMnZYyhUYjWDHaUtco1rSLzECirJq oJgLig0/Ob9WUlYTn4Or =rYLb -----END PGP SIGNATURE----- --lv8Dlu5MqJQeL2cIRFkQ1FgPRak2HQtDj--