Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752465AbdGaNEX (ORCPT ); Mon, 31 Jul 2017 09:04:23 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:10805 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751971AbdGaNEW (ORCPT ); Mon, 31 Jul 2017 09:04:22 -0400 Message-ID: <597F2A47.4020209@huawei.com> Date: Mon, 31 Jul 2017 21:01:59 +0800 From: "Longpeng (Mike)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Cornelia Huck , David Hildenbrand CC: , , , , , , , , , , , , Subject: Re: [RFC] KVM: optimize the kvm_vcpu_on_spin References: <1501309377-195256-1-git-send-email-longpeng2@huawei.com> <597F1DAE.4020809@huawei.com> <20170731143155.30a1b0dd@gondolin> In-Reply-To: <20170731143155.30a1b0dd@gondolin> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.246.209] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090202.597F2AD2.0064,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 92c80961e2eeb00105ca73bc72eb5938 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2006 Lines: 78 On 2017/7/31 20:31, Cornelia Huck wrote: > On Mon, 31 Jul 2017 20:08:14 +0800 > "Longpeng (Mike)" wrote: > >> Hi David, >> >> On 2017/7/31 19:31, David Hildenbrand wrote: > >>>> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h >>>> index 648b34c..f8f0d74 100644 >>>> --- a/include/linux/kvm_host.h >>>> +++ b/include/linux/kvm_host.h >>>> @@ -272,6 +272,9 @@ struct kvm_vcpu { >>>> } spin_loop; >>>> #endif >>>> bool preempted; >>>> + /* If vcpu is in kernel-mode when preempted */ >>>> + bool in_kernmode; >>>> + >>> >>> Why do you have to store that ... >>> >> >>> [...]> + me->in_kernmode = kvm_arch_vcpu_spin_kernmode(me); >>>> kvm_vcpu_set_in_spin_loop(me, true); >>>> /* >>>> * We boost the priority of a VCPU that is runnable but not >>>> @@ -2351,6 +2353,8 @@ void kvm_vcpu_on_spin(struct kvm_vcpu *me) >>>> continue; >>>> if (swait_active(&vcpu->wq) && !kvm_arch_vcpu_runnable(vcpu)) >>>> continue; >>>> + if (me->in_kernmode && !vcpu->in_kernmode) >>> >>> Wouldn't it be easier to simply have >>> >>> in_kernel = kvm_arch_vcpu_in_kernel(me); >>> ... >>> if (in_kernel && !kvm_arch_vcpu_in_kernel(vcpu)) >>> ... >>> >> >> I'm not sure whether the operation of get the vcpu's priority-level is >> expensive on all architectures, so I record it in kvm_sched_out() for >> minimal the extra cycles cost in kvm_vcpu_on_spin(). > > As it is now, this handling looks a bit inconsistent. You only update > the field on sched-out via preemption _or_ if kvm_vcpu_on_spin is > called for the vcpu. In most contexts, this field will have stale > content. > > Also, would checking for kernel mode be more expensive than the various > other checks already done in this function? > > [I like David's suggestion.] > Hi Cornelia & David, I'll take your suggestion, thanks :) >> >>>> + continue; >>>> if (!kvm_vcpu_eligible_for_directed_yield(vcpu)) >>>> continue; >>>> > > . > -- Regards, Longpeng(Mike)