Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751874AbdGaN1z convert rfc822-to-8bit (ORCPT ); Mon, 31 Jul 2017 09:27:55 -0400 Received: from smtp-out4.electric.net ([192.162.216.184]:50102 "EHLO smtp-out4.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979AbdGaN1y (ORCPT ); Mon, 31 Jul 2017 09:27:54 -0400 From: David Laight To: "'SZ Lin'" , "ashleydlai@gmail.com" CC: "linux-kernel@vger.kernel.org" , "jarkko.sakkinen@linux.intel.com" , "jgunthorpe@obsidianresearch.com" , "tpmdd-devel@lists.sourceforge.net" , "paulus@samba.org" , "peterhuewe@gmx.de" , "linuxppc-dev@lists.ozlabs.org" , "tpmdd@selhorst.ne" Subject: RE: [PATCH 1/5] Fix packed and aligned attribute warnings. Thread-Topic: [PATCH 1/5] Fix packed and aligned attribute warnings. Thread-Index: AQHTCFN1TUaK1ruffkyZGSjttiA1t6Jt7+JA Date: Mon, 31 Jul 2017 13:27:47 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD0047420@AcuExch.aculab.com> References: <20170729072433.13194-1-sz.lin@moxa.com> <20170729072433.13194-2-sz.lin@moxa.com> In-Reply-To: <20170729072433.13194-2-sz.lin@moxa.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 156.67.243.126 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuExch.aculab.com X-TLS: TLSv1:AES128-SHA:128 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 578 Lines: 20 From: SZ Lin > Sent: 29 July 2017 08:24 ... > diff --git a/drivers/char/tpm/tpm_ibmvtpm.h b/drivers/char/tpm/tpm_ibmvtpm.h > index 91dfe766d080..9f708ca3dc84 100644 > --- a/drivers/char/tpm/tpm_ibmvtpm.h > +++ b/drivers/char/tpm/tpm_ibmvtpm.h > @@ -25,7 +25,7 @@ struct ibmvtpm_crq { > __be16 len; > __be32 data; > __be64 reserved; > -} __attribute__((packed, aligned(8))); > +} __packed __aligned(8); You can't need __packed and __aligned(8) on that structure. There are no gaps and you are saying it is always aligned. So just remove the pointless attributes. David