Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752422AbdGaOrF (ORCPT ); Mon, 31 Jul 2017 10:47:05 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:46073 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752112AbdGaOrD (ORCPT ); Mon, 31 Jul 2017 10:47:03 -0400 Date: Mon, 31 Jul 2017 16:47:00 +0200 From: Andrew Lunn To: Egil Hjelmeland Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH net-next 2/2] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Message-ID: <20170731144700.GG24562@lunn.ch> References: <20170731113355.4284-1-privat@egil-hjelmeland.no> <20170731113355.4284-3-privat@egil-hjelmeland.no> <20170731134640.GD24562@lunn.ch> <83b3fb27-97dd-a9ea-e0db-017d616f93fe@egil-hjelmeland.no> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83b3fb27-97dd-a9ea-e0db-017d616f93fe@egil-hjelmeland.no> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 479 Lines: 19 > >Reviewed-by: Andrew Lunn > > > > Andrew > > > > Hi Andrew > > This time I took the extra effort to split my original patch... > > Your lan9303_write_switch_port suggestion (in previous reply) is fine. > And I can improve the coverletter. > > So I will do a v2 of the patch. But what is your advice: > Should I squash the patch? I already gave my Reviewed-by:, meaning i don't really care. Merged or squashed is a minor point in this case. Andrew