Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752527AbdGaP52 (ORCPT ); Mon, 31 Jul 2017 11:57:28 -0400 Received: from bran.ispras.ru ([83.149.199.196]:11101 "EHLO smtp.ispras.ru" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752045AbdGaP50 (ORCPT ); Mon, 31 Jul 2017 11:57:26 -0400 X-Greylist: delayed 488 seconds by postgrey-1.27 at vger.kernel.org; Mon, 31 Jul 2017 11:57:26 EDT From: Anton Vasilyev To: Colin Ian King Cc: Anton Vasilyev , Jiri Kosina , linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: [PATCH] misc: Return error on error path Date: Mon, 31 Jul 2017 18:48:33 +0300 Message-Id: <1501516113-6271-1-git-send-email-vasilyev@ispras.ru> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 961 Lines: 32 If ibmasm_event_buffer_init() or ibmasm_heartbeat_init() fails, then ibmasm_init_one() release all resources and return 0 on error path. The patch adds corresponding error for fails. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Anton Vasilyev --- drivers/misc/ibmasm/module.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/misc/ibmasm/module.c b/drivers/misc/ibmasm/module.c index c5a456b..ba76405 100644 --- a/drivers/misc/ibmasm/module.c +++ b/drivers/misc/ibmasm/module.c @@ -96,11 +96,13 @@ static int ibmasm_init_one(struct pci_dev *pdev, const struct pci_device_id *id) if (ibmasm_event_buffer_init(sp)) { dev_err(sp->dev, "Failed to allocate event buffer\n"); + result = -ENOMEM; goto error_eventbuffer; } if (ibmasm_heartbeat_init(sp)) { dev_err(sp->dev, "Failed to allocate heartbeat command\n"); + result = -ENOMEM; goto error_heartbeat; } -- 2.7.4