Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752542AbdGaQZU (ORCPT ); Mon, 31 Jul 2017 12:25:20 -0400 Received: from mail-oi0-f47.google.com ([209.85.218.47]:36701 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752316AbdGaQZS (ORCPT ); Mon, 31 Jul 2017 12:25:18 -0400 MIME-Version: 1.0 In-Reply-To: <1501516113-6271-1-git-send-email-vasilyev@ispras.ru> References: <1501516113-6271-1-git-send-email-vasilyev@ispras.ru> From: Andy Shevchenko Date: Mon, 31 Jul 2017 19:25:17 +0300 Message-ID: Subject: Re: [PATCH] misc: Return error on error path To: Anton Vasilyev Cc: Colin Ian King , Jiri Kosina , "linux-kernel@vger.kernel.org" , ldv-project@linuxtesting.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 942 Lines: 37 On Mon, Jul 31, 2017 at 6:48 PM, Anton Vasilyev wrote: > If ibmasm_event_buffer_init() or ibmasm_heartbeat_init() fails, > then ibmasm_init_one() release all resources and return 0 on error path. > > The patch adds corresponding error for fails. > > Found by Linux Driver Verification project (linuxtesting.org). To me looks better to - return 1; + return -ENOMEM; in event.c, and then... > if (ibmasm_event_buffer_init(sp)) { > dev_err(sp->dev, "Failed to allocate event buffer\n"); > + result = -ENOMEM; > goto error_eventbuffer; > } result = ibmasm_event_buffer_init(sp); if (result) { ... } > if (ibmasm_heartbeat_init(sp)) { > dev_err(sp->dev, "Failed to allocate heartbeat command\n"); > + result = -ENOMEM; > goto error_heartbeat; > } Ditto. -- With Best Regards, Andy Shevchenko