Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751704AbdGaQnZ (ORCPT ); Mon, 31 Jul 2017 12:43:25 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34067 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbdGaQnY (ORCPT ); Mon, 31 Jul 2017 12:43:24 -0400 MIME-Version: 1.0 In-Reply-To: <874ltt0w7w.fsf@e105922-lin.cambridge.arm.com> References: <20170720110402.15313-1-punit.agrawal@arm.com> <20170720110402.15313-3-punit.agrawal@arm.com> <874ltt0w7w.fsf@e105922-lin.cambridge.arm.com> From: Jassi Brar Date: Mon, 31 Jul 2017 22:13:22 +0530 Message-ID: Subject: Re: [PATCH 2/4] mailbox: pcc: Drop uninformative output during boot To: Punit Agrawal Cc: Lorenzo Pieralisi , Sudeep Holla , Linux Kernel Mailing List , "Rafael J. Wysocki" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1443 Lines: 42 [CC'ing Rafael J. Wysocki, who picks patches for pcc.c] On Mon, Jul 31, 2017 at 3:22 PM, Punit Agrawal wrote: > Punit Agrawal writes: > >> When booting on an ACPI enabled system that does not provide the >> Platform Communications Channel Table (PCCT), the pcc mailbox driver >> prints - >> >> [ 0.484261] PCCT header not found. >> >> during probe before returning -ENODEV. >> >> This message clutters the bootlog and doesn't provide any useful >> information. Drop this message. >> >> Signed-off-by: Punit Agrawal >> Cc: Jassi Brar >> --- >> drivers/mailbox/pcc.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c >> index ac91fd0d62c6..3d83cdc11ab5 100644 >> --- a/drivers/mailbox/pcc.c >> +++ b/drivers/mailbox/pcc.c >> @@ -457,10 +457,8 @@ static int __init acpi_pcc_probe(void) >> /* Search for PCCT */ >> status = acpi_get_table(ACPI_SIG_PCCT, 0, &pcct_tbl); >> >> - if (ACPI_FAILURE(status) || !pcct_tbl) { >> - pr_warn("PCCT header not found.\n"); >> + if (ACPI_FAILURE(status) || !pcct_tbl) >> return -ENODEV; >> - } >> >> count = acpi_table_parse_entries(ACPI_SIG_PCCT, >> sizeof(struct acpi_table_pcct), > > Ping! Any comments/concerns with dropping the message? > > Thanks.