MIME-Version: 1.0
In-Reply-To: <87zibktpil.fsf@devron>
References: <20170731143349.84629-1-andriy.shevchenko@linux.intel.com>
 <877eyov49l.fsf@devron> <87zibktpil.fsf@devron>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Mon, 31 Jul 2017 22:31:29 +0300
Message-ID: <CAHp75Vd1gTFuw+ubDpe94uiooakNVHUf0cHDtsoop8dhOBKo9w@mail.gmail.com>
Subject: Re: [PATCH v5] vfat: Deduplicate hex2bin()
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Joe Perches <joe@perches.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 867
Lines: 30

On Mon, Jul 31, 2017 at 9:44 PM, OGAWA Hirofumi
<hirofumi@mail.parknet.co.jp> wrote:
> We may use hex2bin() instead of custom approach.

>  #include <linux/ctype.h>
>  #include <linux/slab.h>
>  #include <linux/namei.h>
> +#include <linux/kernel.h>

Would not be better to squeeze it somehow alphabetically ordered (in
most ordered part)?


> +
> +                               *(wchar_t *)op = uc[0] << 8 | uc[1];
> +
> +                               op += 2;

This had been in the original patch 6 years ago and had been refused
because of endianess issues.

>                                 charlen = nls->char2uni(ip, len - i,
> -                                                                       (wchar_t *)op);
> +                                                       (wchar_t *)op);

It perfectly fits one line.

-- 
With Best Regards,
Andy Shevchenko