Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751824AbdGaURL (ORCPT ); Mon, 31 Jul 2017 16:17:11 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57408 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbdGaURI (ORCPT ); Mon, 31 Jul 2017 16:17:08 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 584DD60AA0 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Mon, 31 Jul 2017 13:17:01 -0700 From: Stephen Boyd To: Sylwester Nawrocki Cc: mturquette@baylibre.com, cw00.choi@samsung.com, krzk@kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: samsung: exynos5420: The EPLL rate table corrections Message-ID: <20170731201701.GI2146@codeaurora.org> References: <1500635990-19474-1-git-send-email-s.nawrocki@samsung.com> <33f53903-9043-29c0-2cb8-e5d6950cc92f@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33f53903-9043-29c0-2cb8-e5d6950cc92f@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1165 Lines: 32 On 07/31, Sylwester Nawrocki wrote: > On 07/21/2017 01:19 PM, Sylwester Nawrocki wrote: > >This patch fixes values of the EPLL K coefficient and changes > >the EPLL output frequency values to match exactly what is > >possible to achieve with given M, P, S, K coefficients. > >This allows to avoid rounding errors and unexpected frequency > >being set with clk_set_rate(), due to recalc_rate returning > >different values than the PLL rate specified in the > >exynos5420_epll_24mhz_tbl table. E.g. this prevents a case > >where two consecutive clk_set_rate() calls with same argument > >result in different PLL output frequency. > > > >The PLL output frequencies have been calculated with formula: > > > >f = fxtal * (M * 2^16 + K) / (P * 2^S) / 2^16 > > > >where fxtal = 24000000. > > > >Fixes: 9842452acd ("clk: samsung: exynos542x: Add EPLL rate table") > >Signed-off-by: Sylwester Nawrocki > > Stephen, Mike, > > Could you apply this patch directly for v4.12-rcX? > It fixes code added in v4.12. > You mean v4.13? Sure. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project