Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751591AbdGaU4j (ORCPT ); Mon, 31 Jul 2017 16:56:39 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:52344 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114AbdGaU4i (ORCPT ); Mon, 31 Jul 2017 16:56:38 -0400 From: OGAWA Hirofumi To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Joe Perches Subject: Re: [PATCH v5] vfat: Deduplicate hex2bin() References: <20170731143349.84629-1-andriy.shevchenko@linux.intel.com> <877eyov49l.fsf@devron> <1501529949.29303.314.camel@linux.intel.com> Date: Tue, 01 Aug 2017 05:56:36 +0900 In-Reply-To: <1501529949.29303.314.camel@linux.intel.com> (Andy Shevchenko's message of "Mon, 31 Jul 2017 22:39:09 +0300") Message-ID: <87r2wwtjej.fsf@devron> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 534 Lines: 16 Andy Shevchenko writes: >> > + fill = hex2bin(hc, ip + 1, 2); >> > + if (fill) >> > + return fill; >> >> This should not use random errno (in this case, it is -1 (EPERM)). > > You perhaps missed the side note I put after --- line. > It reflects this change. Sure, I missed to read it. But same here, hex2bin() doesn't care FS's errno, it is what "random errno" I meant (I.e. hex2bin() might change it to bool or any other errno again). -- OGAWA Hirofumi