Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751681AbdGaXLk (ORCPT ); Mon, 31 Jul 2017 19:11:40 -0400 Received: from gloria.sntech.de ([95.129.55.99]:57330 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbdGaXLj (ORCPT ); Mon, 31 Jul 2017 19:11:39 -0400 From: Heiko Stuebner To: Andy Yan Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org Subject: Re: [PATCH 11/14] ARM: dts: rockchip: add saradc support for rv1108 Date: Tue, 01 Aug 2017 01:11:31 +0200 Message-ID: <15353999.IRu6p5GgJC@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <1501496359-22020-1-git-send-email-andy.yan@rock-chips.com> References: <1501495449-21290-1-git-send-email-andy.yan@rock-chips.com> <1501496359-22020-1-git-send-email-andy.yan@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 780 Lines: 28 Hi Andy, Am Montag, 31. Juli 2017, 18:19:19 CEST schrieb Andy Yan: > Add saradc device tree node for rv1108 > > Signed-off-by: Andy Yan > --- > > arch/arm/boot/dts/rv1108.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi > index 1fc467e..958fecd 100644 > --- a/arch/arm/boot/dts/rv1108.dtsi > +++ b/arch/arm/boot/dts/rv1108.dtsi > @@ -275,6 +275,18 @@ > status = "disabled"; > }; > > + adc: adc@1038c000 { > + compatible = "rockchip,rk3399-saradc"; you should amend the binding txt to make this something like compatible = "rockchip,rv1108-saradc", "rockchip,rk3399-saradc" See for example the bindings/mmc/rockchip-dw-mshc.txt as inspiration. Heiko