Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751800AbdGaXVs (ORCPT ); Mon, 31 Jul 2017 19:21:48 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:36388 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751438AbdGaXVq (ORCPT ); Mon, 31 Jul 2017 19:21:46 -0400 MIME-Version: 1.0 In-Reply-To: <3172146.dPhkKZoKtx@aspire.rjw.lan> References: <7313224.XbtxUoJtXM@aspire.rjw.lan> <3172146.dPhkKZoKtx@aspire.rjw.lan> From: Andy Shevchenko Date: Tue, 1 Aug 2017 02:21:45 +0300 Message-ID: Subject: Re: [PATCH] platform/x86: intel-hid: Wake up Dell Latitude 7275 from suspend-to-idle To: "Rafael J. Wysocki" Cc: Platform Driver , Darren Hart , LKML , Linux ACPI , Andy Shevchenko , =?UTF-8?B?SsOpcsO0bWUgZGUgQnJldGFnbmU=?= , Mario Limonciello , Alex Hung Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6VNLs8p011077 Content-Length: 3214 Lines: 83 On Tue, Aug 1, 2017 at 12:46 AM, Rafael J. Wysocki wrote: > On Friday, July 28, 2017 02:06:36 AM Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> On Dell Latitude 7275 the 5-button array is not exposed in the >> ACPI tables, but still notifies are sent to the Intel HID device >> object (device ID INT33D5) in response to power button actions while >> suspended to idle. However, they are currently ignored as the >> intel-hid driver is not prepared to take care of them. >> >> As a result, power button wakeup from suspend-to-idle doesn't work >> on this platform, but suspend-to-idle is the only reliable suspend >> variant on it (the S3 implementation in the platform firmware turns >> out to be broken), so it would be good to handle it properly. >> >> For this reason, add an upfront check against the power button press >> event (0xCE) to notify_handler() in the wakeup mode which allows it >> to catch the power button wakeup notification on the affected >> platform (even though priv->array is NULL on it) and should not >> change the behavior on platforms with priv->array present (because >> priv->array contains the event in question in those cases). >> >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=196115 >> Tested-by: Jérôme de Bretagne >> Signed-off-by: Rafael J. Wysocki > > Please note that this change is requisite for > > https://patchwork.kernel.org/patch/9873159/ > > so are there any objections or concerns? Not from my side, Acked-by: Andy Shevchenko > >> --- >> drivers/platform/x86/intel-hid.c | 17 ++++++++++++++--- >> 1 file changed, 14 insertions(+), 3 deletions(-) >> >> Index: linux-pm/drivers/platform/x86/intel-hid.c >> =================================================================== >> --- linux-pm.orig/drivers/platform/x86/intel-hid.c >> +++ linux-pm/drivers/platform/x86/intel-hid.c >> @@ -203,15 +203,26 @@ static void notify_handler(acpi_handle h >> acpi_status status; >> >> if (priv->wakeup_mode) { >> + /* >> + * Needed for wakeup from suspend-to-idle to work on some >> + * platforms that don't expose the 5-button array, but still >> + * send notifies with the power button event code to this >> + * device object on power button actions while suspended. >> + */ >> + if (event == 0xce) >> + goto wakeup; >> + >> /* Wake up on 5-button array events only. */ >> if (event == 0xc0 || !priv->array) >> return; >> >> - if (sparse_keymap_entry_from_scancode(priv->array, event)) >> - pm_wakeup_hard_event(&device->dev); >> - else >> + if (!sparse_keymap_entry_from_scancode(priv->array, event)) { >> dev_info(&device->dev, "unknown event 0x%x\n", event); >> + return; >> + } >> >> +wakeup: >> + pm_wakeup_hard_event(&device->dev); >> return; >> } >> >> > -- With Best Regards, Andy Shevchenko