Date: Tue, 1 Aug 2017 10:50:29 +1000 (AEST)
From: James Morris <jmorris@namei.org>
To: Kees Cook <keescook@chromium.org>
cc: Andrew Morton <akpm@linux-foundation.org>,
        Casey Schaufler <casey@schaufler-ca.com>,
        David Howells <dhowells@redhat.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        John Johansen <john.johansen@canonical.com>,
        "Serge E. Hallyn" <serge@hallyn.com>, Paul Moore <paul@paul-moore.com>,
        Stephen Smalley <sds@tycho.nsa.gov>,
        Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
        James Morris <james.l.morris@oracle.com>,
        Andy Lutomirski <luto@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 12/15] smack: Remove redundant pdeath_signal
 clearing
In-Reply-To: <1501545093-56634-13-git-send-email-keescook@chromium.org>
Message-ID: <alpine.LRH.2.20.1708011050170.6845@namei.org>
References: <1501545093-56634-1-git-send-email-keescook@chromium.org> <1501545093-56634-13-git-send-email-keescook@chromium.org>
User-Agent: Alpine 2.20 (LRH 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 707
Lines: 22

On Mon, 31 Jul 2017, Kees Cook wrote:

> This removes the redundant pdeath_signal clearing in Smack: the check in
> smack_bprm_committing_creds() matches the check in smack_bprm_set_creds()
> (which used to be in the now-removed smack_bprm_securexec() hook) and
> since secureexec is now being checked for clearing pdeath_signal, this
> is redundant to the common exec code.
> 
> Cc: Casey Schaufler <casey@schaufler-ca.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Acked-by: Serge Hallyn <serge@hallyn.com>
> ---
>  security/smack/smack_lsm.c | 15 ---------------
>  1 file changed, 15 deletions(-)


Reviewed-by: James Morris <james.l.morris@oracle.com>


-- 
James Morris
<jmorris@namei.org>