Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751813AbdHAD1K (ORCPT ); Mon, 31 Jul 2017 23:27:10 -0400 Received: from mga14.intel.com ([192.55.52.115]:9950 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751740AbdHAD1J (ORCPT ); Mon, 31 Jul 2017 23:27:09 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,304,1498546800"; d="scan'208";a="114127622" Date: Tue, 1 Aug 2017 09:00:06 +0530 From: Vinod Koul To: Cheng-Yi Chiang , Jie Yang Cc: linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , "U . Artie Eoff" , alsa-devel@alsa-project.org Subject: Re: [PATCH v2] ASoC: Intel: Reset hw_ptr on resume trigger Message-ID: <20170801033006.GL3053@localhost> References: <20170731104734.5776-1-cychiang@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170731104734.5776-1-cychiang@chromium.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1276 Lines: 38 On Mon, Jul 31, 2017 at 06:47:34PM +0800, Cheng-Yi Chiang wrote: > From: "U. Artie Eoff" > > Reset the hw_ptr before queuing the restore_stream_context > work to eradicate a nasty white audio noise on resume. Liam, Jie? This on legacy BYT driver.. > > Tested-by: Cheng-Yi Chiang > Signed-off-by: U. Artie Eoff > Signed-off-by: Cheng-Yi Chiang > --- > sound/soc/intel/baytrail/sst-baytrail-pcm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/intel/baytrail/sst-baytrail-pcm.c b/sound/soc/intel/baytrail/sst-baytrail-pcm.c > index 4765ad474544..e0db7070cd42 100644 > --- a/sound/soc/intel/baytrail/sst-baytrail-pcm.c > +++ b/sound/soc/intel/baytrail/sst-baytrail-pcm.c > @@ -187,8 +187,10 @@ static int sst_byt_pcm_trigger(struct snd_pcm_substream *substream, int cmd) > sst_byt_stream_start(byt, pcm_data->stream, 0); > break; > case SNDRV_PCM_TRIGGER_RESUME: > - if (pdata->restore_stream == true) > + if (pdata->restore_stream == true) { > + pcm_data->hw_ptr = 0; > schedule_work(&pcm_data->work); > + } > else > sst_byt_stream_resume(byt, pcm_data->stream); > break; > -- > 2.12.2 > -- ~Vinod