Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751901AbdHAEdE convert rfc822-to-8bit (ORCPT ); Tue, 1 Aug 2017 00:33:04 -0400 Received: from mga06.intel.com ([134.134.136.31]:61109 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751886AbdHAEdA (ORCPT ); Tue, 1 Aug 2017 00:33:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,305,1498546800"; d="scan'208";a="134353147" From: "Eoff, Ullysses A" To: "Koul, Vinod" , Cheng-Yi Chiang , "Jie, Yang" CC: "linux-kernel@vger.kernel.org" , "Liam Girdwood" , Mark Brown , "Jaroslav Kysela" , Takashi Iwai , "alsa-devel@alsa-project.org" Subject: RE: [PATCH v2] ASoC: Intel: Reset hw_ptr on resume trigger Thread-Topic: [PATCH v2] ASoC: Intel: Reset hw_ptr on resume trigger Thread-Index: AQHTCeqbCPiA5/WBTUS3z5dJifyuD6JvTnMA//+V8ZA= Date: Tue, 1 Aug 2017 04:32:56 +0000 Message-ID: <8B5BDC21C48FAF4CA5D7E3FE1A63A9087407DE4D@ORSMSX111.amr.corp.intel.com> References: <20170731104734.5776-1-cychiang@chromium.org> <20170801033006.GL3053@localhost> In-Reply-To: <20170801033006.GL3053@localhost> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODcwZjlkNzgtYjkyNi00NzQ3LTk1NTUtNTdiZWQ0M2NlOTUxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImxPazFyTmo1TU1sYkorc0tEak5jNGhCd01aXC9meEx4YlF5ckMwR1k4U1wvcz0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2012 Lines: 49 This patch was originally submitted in the context of the ChromiumOS kernel 3.10 for BYT (https://groups.google.com/a/chromium.org/forum/#!topic/chromium-os-reviews/AsoBhfHzQg8). > -----Original Message----- > From: Koul, Vinod > Sent: Monday, July 31, 2017 8:30 PM > To: Cheng-Yi Chiang ; Jie, Yang > Cc: linux-kernel@vger.kernel.org; Liam Girdwood ; Mark Brown ; Jaroslav Kysela > ; Takashi Iwai ; Eoff, Ullysses A ; alsa-devel@alsa-project.org > Subject: Re: [PATCH v2] ASoC: Intel: Reset hw_ptr on resume trigger > > On Mon, Jul 31, 2017 at 06:47:34PM +0800, Cheng-Yi Chiang wrote: > > From: "U. Artie Eoff" > > > > Reset the hw_ptr before queuing the restore_stream_context > > work to eradicate a nasty white audio noise on resume. > > Liam, Jie? This on legacy BYT driver.. > > > > > Tested-by: Cheng-Yi Chiang > > Signed-off-by: U. Artie Eoff > > Signed-off-by: Cheng-Yi Chiang > > --- > > sound/soc/intel/baytrail/sst-baytrail-pcm.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/sound/soc/intel/baytrail/sst-baytrail-pcm.c b/sound/soc/intel/baytrail/sst-baytrail-pcm.c > > index 4765ad474544..e0db7070cd42 100644 > > --- a/sound/soc/intel/baytrail/sst-baytrail-pcm.c > > +++ b/sound/soc/intel/baytrail/sst-baytrail-pcm.c > > @@ -187,8 +187,10 @@ static int sst_byt_pcm_trigger(struct snd_pcm_substream *substream, int cmd) > > sst_byt_stream_start(byt, pcm_data->stream, 0); > > break; > > case SNDRV_PCM_TRIGGER_RESUME: > > - if (pdata->restore_stream == true) > > + if (pdata->restore_stream == true) { > > + pcm_data->hw_ptr = 0; > > schedule_work(&pcm_data->work); > > + } > > else > > sst_byt_stream_resume(byt, pcm_data->stream); > > break; > > -- > > 2.12.2 > > > > -- > ~Vinod