Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676AbdHAGyU (ORCPT ); Tue, 1 Aug 2017 02:54:20 -0400 Received: from ozlabs.org ([103.22.144.67]:57229 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751571AbdHAGyS (ORCPT ); Tue, 1 Aug 2017 02:54:18 -0400 From: Michael Ellerman To: Brian King Cc: Jens Axboe , Brian J King , "linux-kernel\@vger.kernel.org" , "linux-block\@vger.kernel.org" , Bart Van Assche , "linuxppc-dev\@lists.ozlabs.org" Subject: Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage In-Reply-To: <87379c6cfh.fsf@concordia.ellerman.id.au> References: <87a83qfosu.fsf@concordia.ellerman.id.au> <073ed79c-11ce-e86c-a905-91fd28675d47@kernel.dk> <1501166846.2516.1.camel@wdc.com> <5b85a365-faa1-3987-9b6b-270399c30686@kernel.dk> <87lgn9dqx3.fsf@concordia.ellerman.id.au> <92379297-9667-ae52-b05c-6c8a0ce4751c@kernel.dk> <5dcfe3ac-50c7-86a6-e571-fe5a1c1dc316@linux.vnet.ibm.com> <87379c6cfh.fsf@concordia.ellerman.id.au> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 01 Aug 2017 16:54:16 +1000 Message-ID: <87a83ju6av.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 831 Lines: 27 Michael Ellerman writes: > Brian King writes: > >> On 07/28/2017 10:17 AM, Brian J King wrote: >>> Jens Axboe wrote on 07/28/2017 09:25:48 AM: >>> >>>> Can you try the below fix? Should be more palatable than the previous >>>> one. Brian, maybe you can take a look at the IRQ issue mentioned above? >> >> Michael, >> >> Does this address the issue you are seeing? > > Yes it seems to, thanks. > > I only see the trace on reboot, and not 100% of the time. But I've > survived a couple of reboots now without seeing anything, so I think > this is helping. > > I'll put the patch in my Jenkins over night and let you know how it > survives that, which should be ~= 25 boots. No lockdep warnings or other oddness over night, so that patch looks good to me. cheers