Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751747AbdHAIv2 (ORCPT ); Tue, 1 Aug 2017 04:51:28 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:5586 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751003AbdHAIv0 (ORCPT ); Tue, 1 Aug 2017 04:51:26 -0400 Message-ID: <1501577481.32089.3.camel@mtksdaap41> Subject: Re: [PATCH v5 2/2] arm64: dts: Add Mediatek SoC MT2712 and evaluation board dts and Makefile From: Yingjoe Chen To: YT Shen , Matthias Brugger CC: Rob Herring , Mark Rutland , , Jason Cooper , , Marc Zyngier , "Catalin Marinas" , Will Deacon , , Mars Cheng , , Greg Kroah-Hartman , , "Thomas Gleixner" , Date: Tue, 1 Aug 2017 16:51:21 +0800 In-Reply-To: <1501241835-47849-3-git-send-email-yt.shen@mediatek.com> References: <1501241835-47849-1-git-send-email-yt.shen@mediatek.com> <1501241835-47849-3-git-send-email-yt.shen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 888 Lines: 35 On Fri, 2017-07-28 at 19:37 +0800, YT Shen wrote: > diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi > new file mode 100644 > index 0000000..1e135af > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi <...> > + timer { > + compatible = "arm,armv8-timer"; > + interrupt-parent = <&gic>; > + interrupts = + (GIC_CPU_MASK_RAW(0x13) | IRQ_TYPE_LEVEL_LOW)>, > + + (GIC_CPU_MASK_RAW(0x13) | IRQ_TYPE_LEVEL_LOW)>, > + + (GIC_CPU_MASK_RAW(0x13) | IRQ_TYPE_LEVEL_LOW)>, > + + (GIC_CPU_MASK_RAW(0x13) | IRQ_TYPE_LEVEL_LOW)>; > + }; > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + compatible = "simple-bus"; > + ranges; Matthias, I notice this have soc node. Do we need to get rid of it? Joe.C