Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905AbdHAK3G (ORCPT ); Tue, 1 Aug 2017 06:29:06 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:45519 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751657AbdHAK3F (ORCPT ); Tue, 1 Aug 2017 06:29:05 -0400 From: Laurent Pinchart To: Linus Walleij Cc: Lee Jones , Daniel Thompson , Jingoo Han , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2 v2] backlight: gpio: Convert to use GPIO descriptor Date: Tue, 01 Aug 2017 13:29:16 +0300 Message-ID: <1756887.aE0tBDJMo9@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.34-gentoo; KDE/4.14.32; x86_64; ; ) In-Reply-To: References: <20170530114822.24308-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1020 Lines: 36 Hi Linus, Thank you for the patch. On Tuesday 01 Aug 2017 10:20:32 Linus Walleij wrote: > On Tue, May 30, 2017 at 1:48 PM, Linus Walleij wrote: > > This driver is predominantly used by device tree systems, all > > of which can deal with modern GPIO descriptors. The legacy > > GPIO API is only used by one SH board so make the GPIO > > descriptor the default way to deal with it. > > > > As an intended side effect we do not need to look around in > > the device tree for the inversion flag since the GPIO > > descriptors will intrinsically deal with this. > > > > Acked-by: Daniel Thompson > > Signed-off-by: Linus Walleij Reviewed-by: Laurent Pinchart > > --- > > ChangeLog v1->v2: > > - Assign flags value using the ternary operator. > > This patch seems to have been inadvertedly dropped? > > Can it be applied, along with 2/2? > > Yours, > Linus Walleij -- Regards, Laurent Pinchart