Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751835AbdHAM3A (ORCPT ); Tue, 1 Aug 2017 08:29:00 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:36910 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751368AbdHAM27 (ORCPT ); Tue, 1 Aug 2017 08:28:59 -0400 Date: Tue, 1 Aug 2017 13:28:40 +0100 From: Mark Brown To: Srinivas Kandagatla Cc: Arnaud Pouliquen , Jyri Sarha , alsa-devel@alsa-project.org, Archit Taneja , David Airlie , linux-kernel@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Takashi Iwai , Andrzej Hajda Message-ID: <20170801122840.6demhukafhtpeaby@sirena.org.uk> References: <20170731224944.9986-1-srinivas.kandagatla@linaro.org> <20170731224944.9986-3-srinivas.kandagatla@linaro.org> <7d700845-da72-5c40-31f9-c3faa7ca93a2@st.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ddnwx6gmg6fvnqle" Content-Disposition: inline In-Reply-To: X-Cookie: You are lost in the Swamps of Despair. User-Agent: NeoMutt/20170609 (1.8.3) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [alsa-devel] [PATCH v2 2/2] drm/bridge: adv7511: restrict audio sample sizes X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1874 Lines: 50 --ddnwx6gmg6fvnqle Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 01, 2017 at 01:24:03PM +0100, Srinivas Kandagatla wrote: > On 01/08/17 09:42, Arnaud Pouliquen wrote: > > On 08/01/2017 12:49 AM, srinivas.kandagatla@linaro.org wrote: > > I already used ADV7513 and i did not observe this limitation. > > I had a look to ADV7533 data-sheet. it should support 32 and 64 bits I2S > ADV7511_REG_AUDIO_CFG3(0x14) register definition in datasheet and the code > in this driver suggest that It only supports 16Bit and 24Bit samples. The amount of data it pays attention to in the frame is not the same as the size of the frame. > > format bus, with 16 or 24 bits precision sample. So it should support > > SNDRV_PCM_FMTBIT_S32_LE and SNDRV_PCM_FMTBIT_S32_BE > > As example, if you configure bus in Left justified format with 24 bits > > sample length, 32 bits application samples should be truncated to 24 > > bits samples at ADV7533 I2S interface level (LSB dropped). > May be we can do that to make the user happy but isn't this just truncate > the resolution to 24Bit then? > And it's a false indication that we are supporting 32bit samples. > Which am not very happy with. This is what the sample_bits field in the DAI structure is for. --ddnwx6gmg6fvnqle Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmAc/cACgkQJNaLcl1U h9AHxAf/cfD2Oxtod1b0UknZgBlPpTK/wQyWhWNHuyCLB6Jk5ZajYBqE6B1ZkgtX FGLxq+8K5O2vtOGI7N7d/tthXi+dyZyYfD95UujbB3xADH8QDr002h9SDS0RASE4 vPiSyYsrcB2BuS93fQ7cVnyYgRGr1yUPjz8/9vJjgrVQBMMh2hudNUJdzWo9yArB RDzyhefYzrBNE7uWfYTW3X1NYIGaKYPcMyI1Mn3ewWEe8Z4ZKoCS3UKzpUTSWP9A +K/5u8f9GaTyxAjAHAyHg3NP0lUyPTkW+zIDUibm/DZxbXiE7rFFsZBW27gJ8um9 CaDTKvwNpHOBDRkH5kzJRI87qoCZyA== =YlHQ -----END PGP SIGNATURE----- --ddnwx6gmg6fvnqle--