Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751894AbdHAMcL (ORCPT ); Tue, 1 Aug 2017 08:32:11 -0400 Received: from aibo.runbox.com ([91.220.196.211]:60202 "EHLO aibo.runbox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008AbdHAMcJ (ORCPT ); Tue, 1 Aug 2017 08:32:09 -0400 Subject: Re: [PATCH v2 net-next 2/3] net: dsa: lan9303: define LAN9303_NUM_PORTS 3 To: Juergen Borleis , kernel@pengutronix.de Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170801111439.1143-1-privat@egil-hjelmeland.no> <20170801111439.1143-3-privat@egil-hjelmeland.no> <201708011349.52529.jbe@pengutronix.de> From: Egil Hjelmeland Message-ID: <10b6b9fc-d2f9-1761-802f-724d9f6b3df1@egil-hjelmeland.no> Date: Tue, 1 Aug 2017 14:31:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <201708011349.52529.jbe@pengutronix.de> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 587 Lines: 25 On 01. aug. 2017 13:49, Juergen Borleis wrote: > Hi Egil, > > On Tuesday 01 August 2017 13:14:38 Egil Hjelmeland wrote: >> Will be used instead of '3' in upcomming patches. >> >> >> +#define LAN9303_NUM_PORTS 3 >> + > > Maybe we should put this macro into a shared location because > in "net/dsa/tag_lan9303.c" there is already a "#define LAN9303_MAX_PORTS > 3". > > jb > Is there any suitable shared location for such driver specific definitions? I could change the name to LAN9303_MAX_PORTS so it the same. Rhymes better with DSA_MAX_PORTS too. Let's hear what other mean. Egil