Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752269AbdHANRG (ORCPT ); Tue, 1 Aug 2017 09:17:06 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60042 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869AbdHANPm (ORCPT ); Tue, 1 Aug 2017 09:15:42 -0400 Date: Tue, 1 Aug 2017 14:15:24 +0100 From: Mark Brown To: Srinivas Kandagatla Cc: Arnaud Pouliquen , Jyri Sarha , alsa-devel@alsa-project.org, Archit Taneja , David Airlie , linux-kernel@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Takashi Iwai , Andrzej Hajda Message-ID: <20170801131524.zv6nfyzmzal622fl@sirena.org.uk> References: <20170731224944.9986-1-srinivas.kandagatla@linaro.org> <20170731224944.9986-3-srinivas.kandagatla@linaro.org> <7d700845-da72-5c40-31f9-c3faa7ca93a2@st.com> <20170801122840.6demhukafhtpeaby@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mowmg6wnhl5skm5u" Content-Disposition: inline In-Reply-To: X-Cookie: You are lost in the Swamps of Despair. User-Agent: NeoMutt/20170609 (1.8.3) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [alsa-devel] [PATCH v2 2/2] drm/bridge: adv7511: restrict audio sample sizes X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 35 --mowmg6wnhl5skm5u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 01, 2017 at 01:52:35PM +0100, Srinivas Kandagatla wrote: > On 01/08/17 13:28, Mark Brown wrote: > > > And it's a false indication that we are supporting 32bit samples. > > > Which am not very happy with. > > This is what the sample_bits field in the DAI structure is for.ya. > But still reporting that driver supports 32 bit samples when it does not > really support all 32 bits, is kinda misleading to user. > Isn't it? No. Please read what I wrote and look at what setting sample_bits does. --mowmg6wnhl5skm5u Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlmAfusACgkQJNaLcl1U h9DrbAf/WNzRY28s68n77qwy6ZY3i5YFS9P7GtMjnk2ZbPJLeBUrrOPeJckyiGuJ 8MkQbR4Pk/FUMjdraBaqEBKL8PH++lZQkt4RlaDAmEpx3cWwoULZo+TJgtEqYgYq pbw7khSTlF45VUMPe8bciq8w0m0k3W9GFqM3QOpk8crbe3LbFuOlR2KGPBExLKFD GB2NPrXk7TjUg385E/uC3a1p87LvUBn7IYWR9WWkNhYfRLewzf1ckbnoK8Ia0LDr qvT6j6cdxOuVuwbleyC6jA0kGcUzZHxUqS89ZzQRH8f1nchL7SUB1G36BA0E1mZF d9RqpXGzw+UmvmUZttT9Mls1/PqFcg== =4VO9 -----END PGP SIGNATURE----- --mowmg6wnhl5skm5u--