Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752023AbdHANuT (ORCPT ); Tue, 1 Aug 2017 09:50:19 -0400 Received: from aibo.runbox.com ([91.220.196.211]:48648 "EHLO aibo.runbox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737AbdHANuQ (ORCPT ); Tue, 1 Aug 2017 09:50:16 -0400 Subject: Re: [PATCH v2 net-next 1/3] net: dsa: lan9303: Refactor lan9303_xxx_packet_processing() To: Andrew Lunn Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de References: <20170801111439.1143-1-privat@egil-hjelmeland.no> <20170801111439.1143-2-privat@egil-hjelmeland.no> <20170801133934.GB23157@lunn.ch> From: Egil Hjelmeland Message-ID: Date: Tue, 1 Aug 2017 15:50:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170801133934.GB23157@lunn.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 934 Lines: 32 On 01. aug. 2017 15:39, Andrew Lunn wrote: >> @@ -704,7 +710,7 @@ static void lan9303_get_ethtool_stats(struct dsa_switch *ds, int port, >> unsigned int u, poff; >> int ret; >> >> - poff = port * 0x400; >> + poff = LAN9303_SWITCH_PORT_REG(port, 0); >> >> for (u = 0; u < ARRAY_SIZE(lan9303_mib); u++) { >> ret = lan9303_read_switch_reg(chip, > > So the actual code is: > > for (u = 0; u < ARRAY_SIZE(lan9303_mib); u++) { > ret = lan9303_read_switch_reg(chip, > lan9303_mib[u].offset + poff, > ®); > > Could this be written as > > for (u = 0; u < ARRAY_SIZE(lan9303_mib); u++) { > ret = lan9303_read_switch_port(chip, port, lan9303_mib[u].offset, ®); > > It is then clear you are reading the statistics from a port register. > > Andrew > Yes it can. Since it is (insignificantly) less efficient, I chose not to touch it. But I can do it if you like. Egil