Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751916AbdHANyD (ORCPT <rfc822;w@1wt.eu>);
        Tue, 1 Aug 2017 09:54:03 -0400
Received: from mailout3.samsung.com ([203.254.224.33]:64534 "EHLO
        mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751012AbdHANxd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 1 Aug 2017 09:53:33 -0400
X-AuditID: b6c32a48-f79a16d00000362a-c9-598087db0cf3
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: spock@gentoo.org, linux-fbdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: uvesafb: constify attribute_group
 structures.
Date: Tue, 01 Aug 2017 15:53:28 +0200
Message-id: <2391550.2naV14eqVs@amdc3058>
User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <aa3e89c4a81699a5e7799f9c20cc7a123e2fce37.1500441256.git.arvind.yadav.cs@gmail.com>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset="us-ascii"
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBIsWRmVeSWpSXmKPExsWy7bCmhe7t9oZIg63v5C2u9S5ktjjR94HV
        4vKuOWwWUz4eZ3Zg8bj8/Q2zx85Zd9k9Pm+SC2CO4rJJSc3JLEst0rdL4Mpo3LaFvaCXreLg
        pClsDYynWLoYOTgkBEwkPm927GLkBDLFJC7cW8/WxcjFISSwg1GirfkbO4TzmVHi2IwZbDAN
        93fJQsTXMkpsedTFCOF8ZZQ4deMpG8goNgEriYntqxhBbBEBHYlNM3+D2cwCgRKbmuaxgtjC
        AkESXSubwWwWAVWJSXubwXp5BTQlFvZdZQaxRQW8JLbsa2cCsTkFkiSOzW1hhKgRlPgx+R4L
        xEx5iX37p7JC2DoSZ4+tAztIQqCZXWLO282sEFfLSmw6wAzxpovE1yur2SBsYYlXx7ewQ9hS
        Et0ds6Ds6YwS239LQMzZzCixavcEqIS1xOHjF6GW8Ul0HP7LDjGfV6KjTQjC9JDYsZAVotpR
        Yu2GP9AQBRpz99A05gmM8rOQvDALyQuzkLywgJF5FaNYakFxbnpqsVGBiV5xYm5xaV66XnJ+
        7iZGcHrQ8tjBeOCczyFGAQ5GJR7eDS0NkUKsiWXFlbmHGCU4mJVEeKvKgEK8KYmVValF+fFF
        pTmpxYcYpTlYlMR567ZdixASSE8sSc1OTS1ILYLJMnFwSjUwBmwWn1Qt4Kpbrf8qdrKC5I22
        x6cEtn+0WCS2t753wYYtAW56h7t2cd6bK337cdyMiu+ygkW3+X+mtbT/vrsvV14s4u2/tVu0
        GR+uWfjzi47+lLTjW++KbN549JDxXkN/LoX6j6ePPheOqHq4ZB1TEsv2sA8/BLdsXOX4PUKF
        tdPvNZv/pLhZlUosxRmJhlrMRcWJAI/LPBELAwAA
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsVy+t9jQd3b7Q2RBn1fhSyu9S5ktjjR94HV
        4vKuOWwWUz4eZ3Zg8bj8/Q2zx85Zd9k9Pm+SC2COcrPJSE1MSS1SSM1Lzk/JzEu3VQoNcdO1
        UFLIS8xNtVWK0PUNCVJSKEvMKQXyjAzQgINzgHuwkr5dgltG47Yt7AW9bBUHJ01ha2A8xdLF
        yMEhIWAicX+XbBcjJ5ApJnHh3nq2LkYuDiGB1YwSzyfuYIVwvjJKLJo+gw2kik3ASmJi+ypG
        EFtEQEdi08zfYDazgL9Ey5WvzCBDhQUCJHrOqYKEWQRUJSbtbQZr5RXQlFjYd5UZxBYV8JLY
        sq+dCcTmFEiSuN96iR1i11ZGiemXm1kgGgQlfky+xwIxX15i3/6prBC2lsT6nceZJjAKzEJS
        NgtJ2SwkZQsYmVcxiqUWFOem5xYbFRjpFSfmFpfmpesl5+duYgRGy7bDWgE7GJvORR9iFOBg
        VOLh5QBGkRBrYllxZe4hRgkOZiUR3qoyoBBvSmJlVWpRfnxRaU5q8SFGU6D/JjJLiSbnAyM5
        ryTe0MTSyMTAzMzQyMDYTEmcd0LglwghgfTEktTs1NSC1CKYPiYOTqkGxvW+J1TOnu/cWzAx
        61Xgt/X/D/Wn7RSbszbeKptFY+/WumuTC194nstdVWyeJna/b0Kf/yyvrw9Z9S+ICT1jUMs/
        WRnod5s5466YaoS81cmFj37+SNNa2fDizbSW99xXJdImSP77dG7p5POTju3ekxi1aXfXu2y5
        S++W7968ksPv+f0rHQwe5/YqsRRnJBpqMRcVJwIAlaVrfqwCAAA=
X-MTR: 20000000000000000@CPGS
X-CMS-MailID: 20170801135331epcas2p49ba3c7862b7a3d426c0c1992d9dfbdc8
X-Msg-Generator: CA
X-Sender-IP: 182.195.42.80
X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?=
        =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?=
X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?=
        =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?=
        =?UTF-8?B?bmdpbmVlcg==?=
X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?=
CMS-TYPE: 102P
X-CMS-RootMailID: 20170719051736epcas5p3b707e162f6741c876a069f0eb0768fd7
X-RootMTR: 20170719051736epcas5p3b707e162f6741c876a069f0eb0768fd7
References: <CGME20170719051736epcas5p3b707e162f6741c876a069f0eb0768fd7@epcas5p3.samsung.com>
        <aa3e89c4a81699a5e7799f9c20cc7a123e2fce37.1500441256.git.arvind.yadav.cs@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 757
Lines: 22

On Wednesday, July 19, 2017 10:46:55 AM Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   15426	   4952	    187	  20565	   5055	drivers/video/fbdev/uvesafb.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   15490	   4888	    187	  20565	   5055	drivers/video/fbdev/uvesafb.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Patch queued for 4.14, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics