Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751788AbdHAOCI (ORCPT <rfc822;w@1wt.eu>);
        Tue, 1 Aug 2017 10:02:08 -0400
Received: from vps0.lunn.ch ([178.209.37.122]:47856 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751166AbdHAOCH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 1 Aug 2017 10:02:07 -0400
Date: Tue, 1 Aug 2017 16:02:03 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Egil Hjelmeland <privat@egil-hjelmeland.no>
Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de
Subject: Re: [PATCH v2 net-next 1/3] net: dsa: lan9303: Refactor
 lan9303_xxx_packet_processing()
Message-ID: <20170801140203.GC23157@lunn.ch>
References: <20170801111439.1143-1-privat@egil-hjelmeland.no>
 <20170801111439.1143-2-privat@egil-hjelmeland.no>
 <20170801133934.GB23157@lunn.ch>
 <faf9e431-c5e4-7fcc-0341-6fc46e3561fb@egil-hjelmeland.no>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <faf9e431-c5e4-7fcc-0341-6fc46e3561fb@egil-hjelmeland.no>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1315
Lines: 39

On Tue, Aug 01, 2017 at 03:50:14PM +0200, Egil Hjelmeland wrote:
> On 01. aug. 2017 15:39, Andrew Lunn wrote:
> >>@@ -704,7 +710,7 @@ static void lan9303_get_ethtool_stats(struct dsa_switch *ds, int port,
> >>  	unsigned int u, poff;
> >>  	int ret;
> >>-	poff = port * 0x400;
> >>+	poff = LAN9303_SWITCH_PORT_REG(port, 0);
> >>  	for (u = 0; u < ARRAY_SIZE(lan9303_mib); u++) {
> >>  		ret = lan9303_read_switch_reg(chip,
> >
> >So the actual code is:
> >
> >	for (u = 0; u < ARRAY_SIZE(lan9303_mib); u++) {
> >        		ret = lan9303_read_switch_reg(chip,
> >			      		      lan9303_mib[u].offset + poff,
> >					      &reg);
> >
> >Could this be written as
> >
> >	for (u = 0; u < ARRAY_SIZE(lan9303_mib); u++) {
> >		ret = lan9303_read_switch_port(chip, port, lan9303_mib[u].offset, &reg);
> >
> >It is then clear you are reading the statistics from a port register.
> >
> >    Andrew
> >
> 
> Yes it can. Since it is (insignificantly) less efficient, I
> chose not to touch it. But I can do it if you like.

I doubt it is less efficient. The compiler has seen
lan9303_read_switch_port() and will probably inline it.  So what the
optimiser gets to see is probably the same in both cases.

Try generating the assembler listing in both cases, and compare them

make drivers/net/dsa/lan9303-core.lst

     Andrew