Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751805AbdHAOEU (ORCPT ); Tue, 1 Aug 2017 10:04:20 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:63131 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbdHAOES (ORCPT ); Tue, 1 Aug 2017 10:04:18 -0400 X-AuditID: b6c32a39-f794a6d0000049f6-6c-59808a607370 From: Bartlomiej Zolnierkiewicz To: Arvind Yadav Cc: tomi.valkeinen@ti.com, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] omapfb: panel-sony-acx565akm: constify attribute_group structures. Date: Tue, 01 Aug 2017 16:04:12 +0200 Message-id: <4895469.EV6kLxFEj8@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <0daabb462abd99a557da903c961de0eae1782998.1500441926.git.arvind.yadav.cs@gmail.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDIsWRmVeSWpSXmKPExsWy7bCmvm5CV0Okwe4lrBbXehcyW5zo+8Bq cXnXHDaL2Uv6WSzWz7/F5sDqsXPWXXaP4ze2M3l83iQXwBzFZZOSmpNZllqkb5fAldH0so+5 4C9rxafPN5gbGDewdDFyckgImEgcnHeGEcIWk7hwbz1bFyMXh5DADkaJB8eOsIMkhAQ+M0rs 2eAA03Buz252iKK1jBInTy5jhXC+Mkrs+zgZrINNwEpiYvsqsLEiAjoSm2b+BrOZBYokGtae ArOFBSIllm5/ydTFyMHBIqAq8WJVOUiYV0BTovn/GbDrRAW8JLbsa2cCsTkFkiT2ti5nh6gR lPgx+R4LxEh5iX37p7JC2DoSZ4+tYwS5R0KgnV1i25yZLCDzJQRkJTYdYIZ4wEXi6LOjbBC2 sMSr41vYIWwpicaXD5kg7OmMEtt/S0DM2cwosWr3BKgia4nDxy9CLeOTePe1hxViPq9ER5sQ hOkh8eF5MoTpKDGlNwkSOkBTJu19yDKBUX4Wkg9mIflgFpIPFjAyr2IUSy0ozk1PLTYsMNUr TswtLs1L10vOz93ECE4TWpY7GI+d8znEKMDBqMTDy9HeECnEmlhWXJl7iFGCg1lJhLeqDCjE m5JYWZValB9fVJqTWnyIUZqDRUmcV3T9tQghgfTEktTs1NSC1CKYLBMHp1QDo/Rx4cTdHUJr cmewT1kuuWlb1q2/dbsqyydWt3/cpJcrV2qQZ2x48o+cf9p7j3qeLyWs904f3szN/db3xuz0 LtbJPvsiFe/M1gu7aSiWGdCi5iD+4M2zJ1w31bfOLbpfVljotSq6ym6HDJfBvrRpkS8UStWU ijK0dM/8XHaBp77vbE28lCqPEktxRqKhFnNRcSIAT5xzUQ8DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPIsWRmVeSWpSXmKPExsVy+t9jQd34roZIg/tn9C2u9S5ktjjR94HV 4vKuOWwWs5f0s1isn3+LzYHVY+esu+wex29sZ/L4vEkugDnKzSYjNTEltUghNS85PyUzL91W KTTETddCSSEvMTfVVilC1zckSEmhLDGnFMgzMkADDs4B7sFK+nYJbhlNL/uYC/6yVnz6fIO5 gXEDSxcjJ4eEgInEuT272SFsMYkL99azdTFycQgJrGaUWNd9BMr5yiixctc3sCo2ASuJie2r GEFsEQEdiU0zf4PZzAJFEhumnWMDsYUFIiWWbn/J1MXIwcEioCrxYlU5SJhXQFOi+f8ZsMWi Al4SW/a1M4HYnAJJErden2CH2LWVUeLch8+MEA2CEj8m32OBmC8vsW//VFYIW0ti/c7jTBMY BWYhKZuFpGwWkrIFjMyrGMVSC4pz03OLjQoM9YoTc4tL89L1kvNzNzECI2fbYS3/HYw/zkYf YhTgYFTi4eVob4gUYk0sK67MPcQowcGsJMJbVQYU4k1JrKxKLcqPLyrNSS0+xGgK9N5EZinR 5HxgVOeVxBuaWBqZGJiZGRoZGJspifNOCPwSISSQnliSmp2aWpBaBNPHxMEp1cAou/19/Ml1 e17asbappf/fZH8nYvWUpXbeqpVPLvJ663s5ZK6Y3B3A43LarMzwT0Fxgx9vt5nsr9Amjcgc 1RObTk2677s2+7flM9tje2fxWuvdKVeeV2TWIKMt8WDTlYOrq2+oLxZmFdmaXeAnXyojq/Sm Wk15w8ZfbOa+NXY1kt3TJDYlblZiKc5INNRiLipOBAC+B4HjsgIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170801140415epcas1p47e960865ac3461c05766d19f5a6f7df1 X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170719052638epcas3p38153e17e63deab45c6d39fd1c56e3af2 X-RootMTR: 20170719052638epcas3p38153e17e63deab45c6d39fd1c56e3af2 References: <0daabb462abd99a557da903c961de0eae1782998.1500441926.git.arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 741 Lines: 22 On Wednesday, July 19, 2017 10:55:57 AM Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work > with const attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 5227 560 0 5787 169b panel-sony-acx565akm > > File size After adding 'const': > text data bss dec hex filename > 5291 496 0 5787 169b panel-sony-acx565akm.o > > Signed-off-by: Arvind Yadav Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics