Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752014AbdHAOG0 (ORCPT ); Tue, 1 Aug 2017 10:06:26 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:11062 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751758AbdHAOGL (ORCPT ); Tue, 1 Aug 2017 10:06:11 -0400 X-AuditID: b6c32a39-f794a6d0000049f6-1c-59808ad0d9f7 From: Bartlomiej Zolnierkiewicz To: Arvind Yadav Cc: tomi.valkeinen@ti.com, linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] omapfb: panel-tpo-td043mtea1: constify attribute_group structures. Date: Tue, 01 Aug 2017 16:06:06 +0200 Message-id: <4879588.Re4nTIH29Q@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPIsWRmVeSWpSXmKPExsWy7bCmge6FroZIg4knZSyu9S5ktjjR94HV 4vKuOWwWs5f0s1isn3+LzYHVY+esu+wex29sZ/L4vEkugDmKyyYlNSezLLVI3y6BK+PK42vM Bf9ZKz5cOsrcwLiBpYuRk0NCwETi9+5H7BC2mMSFe+vZuhi5OIQEdjBKXJ83lRXC+cwoseXp KVaYjmXvbyNULX6xFqrqK6PE5n0HGEGq2ASsJCa2rwKzRQR0JDbN/A1mMwsUSTSsPQVmCwtE Sqx+0QNmswioSsxeuAnoDg4OXgFNid2LHUHCogJeElv2tTOB2JwCSRJX5+xjBrF5BQQlfky+ xwIxUl5i3/6prBC2jsTZY+sYQe6REGhnlzi+Zw7YTAkBWYlNB5ghHnCRmDT5L9T7whKvjm+B el9KovHlQyYIezqjxPbfEhBzNjNKrNo9AarIWuLw8YtQy/gk3n3tYYWYzyvR0SYEUeIhsfzJ UzYI21Fi78OFTJDwAZrz8chLxgmM8rOQ/DALyQ+zkPywgJF5FaNYakFxbnpqsWGBqV5xYm5x aV66XnJ+7iZGcLLQstzBeOyczyFGAQ5GJR5ejvaGSCHWxLLiytxDjBIczEoivFVlQCHelMTK qtSi/Pii0pzU4kOM0hwsSuK8ouuvRQgJpCeWpGanphakFsFkmTg4pRoYF7rOFp69deOlrus2 0b6WxwPZVrDKSv1iLNhnqNxb/keCqVRL7LfkxO2/Zv1NvDfpwrFnS5dkpPw0fKfY4rO3e5OL TCTjWckQnitPVJ4ssnwWKr7jr+q7DXf2mq8KjFgQZVb4QTVtYqKfxTlRzjXdrInXspiullRX lTN7m22NfibuvH9/j/sLJZbijERDLeai4kQAfxhl6hIDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPIsWRmVeSWpSXmKPExsVy+t9jAd0LXQ2RBm/7+Cyu9S5ktjjR94HV 4vKuOWwWs5f0s1isn3+LzYHVY+esu+wex29sZ/L4vEkugDnKzSYjNTEltUghNS85PyUzL91W KTTETddCSSEvMTfVVilC1zckSEmhLDGnFMgzMkADDs4B7sFK+nYJbhlXHl9jLvjPWvHh0lHm BsYNLF2MnBwSAiYSy97fZoOwxSQu3FsPZHNxCAlsY5RYeWM5O4TzlVHibMtNVpAqNgEriYnt qxhBbBEBHYlNM3+D2cwCRRIbpp0DmyQsECmx+kUPWJxFQFVi9sJNQIM4OHgFNCV2L3YECYsK eEls2dfOBGJzCiRJ7F/5iBVi11ZGiZuXPoDt4hUQlPgx+R4LxHx5iX37p7JC2FoS63ceZ5rA KDALSdksJGWzkJQtYGRexSiWWlCcm55bbFRgqFecmFtcmpeul5yfu4kRGDnbDmv572D8cTb6 EKMAB6MSDy9He0OkEGtiWXFl7iFGCQ5mJRHeqjKgEG9KYmVValF+fFFpTmrxIUZToPcmMkuJ JucDozqvJN7QxNLIxMDMzNDIwNhMSZx3QuCXCCGB9MSS1OzU1ILUIpg+Jg5OqQZG5umWgifv 8xns36cVl1f7Ja5Rp1ZY8dWFS4Zy4U8uf71X/Tr48h52KV3TPdv1Tn3btOjqlor/DQzKu6Q4 TL783H/Kcg/ToYDOmcdZPB42/pEpsbHlDs+Z9s51ldpyNfbp+W8OnDmTGTs3eOIObvHaQCNX NXGhdxHcGfmlE1eE5DgcOSeyK/yAEktxRqKhFnNRcSIAfYc5irICAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170801140608epcas1p40f11c2b293c6626b6f0a773a53e6811b X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170719052351epcas4p20dce52e9c9754e094195d57458529ecb X-RootMTR: 20170719052351epcas4p20dce52e9c9754e094195d57458529ecb References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 743 Lines: 22 On Wednesday, July 19, 2017 10:53:11 AM Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work > with const attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 2673 368 0 3041 be1 panel-tpo-td043mtea1.o > > File size After adding 'const': > text data bss dec hex filename > 2737 304 0 3041 be1 panel-tpo-td043mtea1.o > > Signed-off-by: Arvind Yadav Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics