Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751980AbdHAObQ (ORCPT ); Tue, 1 Aug 2017 10:31:16 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:47904 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751811AbdHAObO (ORCPT ); Tue, 1 Aug 2017 10:31:14 -0400 Date: Tue, 1 Aug 2017 16:31:13 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 00/11] net: dsa: rework EEE support Message-ID: <20170801143113.GF23157@lunn.ch> References: <20170731221719.16695-1-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170731221719.16695-1-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 779 Lines: 18 On Mon, Jul 31, 2017 at 06:17:08PM -0400, Vivien Didelot wrote: > EEE implies configuring the port's PHY and MAC of both ends of the wire. > > The current EEE support in DSA mixes PHY and MAC configuration, which is > bad because PHYs must be configured through a proper PHY driver. The DSA > switch operations for EEE are only meant for configuring the port's MAC, > which are integrated in the Ethernet switch device. > > This patchset fixes the EEE support in qca8k driver, makes the DSA layer > call phy_init_eee for all drivers, and remove the EEE support from the > mv88e6xxx driver since the Marvell PHY driver should be enough for it. Hi Vivien Thanks for working on this. I like the general direction this takes, moving the repeated code into slave.c Andrew