Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751916AbdHAP5p (ORCPT ); Tue, 1 Aug 2017 11:57:45 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:25499 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751670AbdHAP5b (ORCPT ); Tue, 1 Aug 2017 11:57:31 -0400 Subject: Re: [PATCH v2 11/13] xen/pvcalls: implement release command To: Juergen Gross , Stefano Stabellini References: <1501017730-12797-1-git-send-email-sstabellini@kernel.org> <1501017730-12797-11-git-send-email-sstabellini@kernel.org> <81df7507-287b-ee06-89e4-463e82628d10@oracle.com> <7ace9427-5215-6be7-907a-46dd15ea2a8f@suse.com> Cc: xen-devel@lists.xen.org, linux-kernel@vger.kernel.org, Stefano Stabellini From: Boris Ostrovsky Message-ID: <85fbad33-1a27-abaf-f4d2-e93ea47f689c@oracle.com> Date: Tue, 1 Aug 2017 11:57:21 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <7ace9427-5215-6be7-907a-46dd15ea2a8f@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 519 Lines: 18 >> BTW, I also noticed that in rcvmsg you are calling >> wait_event_interruptible() while holding the lock. Have you tested with >> CONFIG_DEBUG_ATOMIC_SLEEP? (or maybe it's some other config option that >> would complain about those sorts of thing) > I believe sleeping while holding a mutex is allowed. Sleeping in > spinlocked paths is bad. Oh, right. I was thinking about spinlocks. Sorry. -boris > > BTW: You are looking for CONFIG_DEBUG_MUTEXES (see > Documentation/locking/mutex-design.txt ). > > > Juergen