Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751887AbdHARAN (ORCPT ); Tue, 1 Aug 2017 13:00:13 -0400 Received: from mx02-sz.bfs.de ([194.94.69.103]:32588 "EHLO mx02-sz.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746AbdHARAM (ORCPT ); Tue, 1 Aug 2017 13:00:12 -0400 Message-ID: <5980B396.7040802@bfs.de> Date: Tue, 01 Aug 2017 19:00:06 +0200 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: Cyrille Pitchen CC: Colin King , Marek Vasut , David Woodhouse , Brian Norris , Boris Brezillon , Richard Weinberger , linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][mtd-next] mtd: spi-nor: remove redundant check on err References: <20170629175054.12231-1-colin.king@canonical.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1590 Lines: 58 Am 01.08.2017 18:33, schrieb Cyrille Pitchen: > Hi Colin, > > Le 29/06/2017 à 19:50, Colin King a écrit : >> From: Colin Ian King >> >> The variable err is not updated since the previous check on it, so >> the subsequent check on err is redundant and can be removed. >> >> Detected by CoverityScan, CID#1448658 ("Logically dead code") >> >> Signed-off-by: Colin Ian King >> --- >> drivers/mtd/spi-nor/spi-nor.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c >> index 196b52f083ae..1296c1931591 100644 >> --- a/drivers/mtd/spi-nor/spi-nor.c >> +++ b/drivers/mtd/spi-nor/spi-nor.c >> @@ -2307,9 +2307,6 @@ static int spi_nor_parse_sfdp(struct spi_nor *nor, >> default: >> break; >> } >> - >> - if (err) >> - goto exit; > > Sorry but this was done on purpose to prepare the structure of the > source code so it's more easy to add later parsing of optional SFDP > tables such as the 4-byte address instruction set table or sector erase > map table. > At that time each case of the switch statement should update the value > of 'err'. > > Best regards, > This is hard to guess, could you add a comment so the next well meaning person has a chance to know that this is onn purpose ? re, wh > Cyrille >> } >> >> exit: >> > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >