Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751904AbdHARIS (ORCPT <rfc822;w@1wt.eu>);
        Tue, 1 Aug 2017 13:08:18 -0400
Received: from esa8.dell-outbound.iphmx.com ([68.232.149.218]:64229 "EHLO
        esa8.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751746AbdHARIQ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 1 Aug 2017 13:08:16 -0400
From: <Mario.Limonciello@dell.com>
X-LoopCount0: from 10.170.28.40
X-IronPort-AV: E=Sophos;i="5.41,306,1498539600"; 
   d="scan'208";a="970157752"
X-DLP: DLP_GlobalPCIDSS
To: <andy.shevchenko@gmail.com>, <rafael@kernel.org>
CC: <rjw@rjwysocki.net>, <platform-driver-x86@vger.kernel.org>,
        <dvhart@infradead.org>, <linux-kernel@vger.kernel.org>,
        <linux-acpi@vger.kernel.org>, <andriy.shevchenko@linux.intel.com>,
        <jerome.debretagne@gmail.com>, <alex.hung@canonical.com>
Subject: RE: [PATCH] platform/x86: intel-hid: Wake up Dell Latitude 7275 from
 suspend-to-idle
Thread-Topic: [PATCH] platform/x86: intel-hid: Wake up Dell Latitude 7275 from
 suspend-to-idle
Thread-Index: AQHTCkecgKSolOFl2U2wMGSfno816aJu5s+AgADS5oCAAAtjgP//8P4A
Date: Tue, 1 Aug 2017 17:04:45 +0000
Message-ID: <739eedabac12425e8e59f8391da4b607@ausx13mpc120.AMER.DELL.COM>
References: <7313224.XbtxUoJtXM@aspire.rjw.lan>
 <3172146.dPhkKZoKtx@aspire.rjw.lan>
 <CAHp75VfouHVbj0X3PJfRHy2uSziq-P__N5ezbmsuUNYDwDxYKg@mail.gmail.com>
 <CAJZ5v0jimcsL3+BfyfjSxjZRjWVFXunPRDquCp-V1SHi32f+=w@mail.gmail.com>
 <CAHp75Vd-LcCR3k3-LTNYNzh-aomGcqgszFWw7HFb-u1+UJLX3A@mail.gmail.com>
In-Reply-To: <CAHp75Vd-LcCR3k3-LTNYNzh-aomGcqgszFWw7HFb-u1+UJLX3A@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.143.242.75]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id v71H8NIP013314
Content-Length: 1967
Lines: 51

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> Sent: Tuesday, August 1, 2017 7:37 AM
> To: Rafael J. Wysocki <rafael@kernel.org>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>; Platform Driver <platform-driver-
> x86@vger.kernel.org>; Darren Hart <dvhart@infradead.org>; LKML <linux-
> kernel@vger.kernel.org>; Linux ACPI <linux-acpi@vger.kernel.org>; Andy
> Shevchenko <andriy.shevchenko@linux.intel.com>; Jérôme de Bretagne
> <jerome.debretagne@gmail.com>; Limonciello, Mario
> <Mario_Limonciello@Dell.com>; Alex Hung <alex.hung@canonical.com>
> Subject: Re: [PATCH] platform/x86: intel-hid: Wake up Dell Latitude 7275 from
> suspend-to-idle
> 
> On Tue, Aug 1, 2017 at 2:56 PM, Rafael J. Wysocki <rafael@kernel.org> wrote:
> > On Tue, Aug 1, 2017 at 1:21 AM, Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> >> On Tue, Aug 1, 2017 at 12:46 AM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> >>> On Friday, July 28, 2017 02:06:36 AM Rafael J. Wysocki wrote:
> 
> >>> Please note that this change is requisite for
> >>>
> >>> https://patchwork.kernel.org/patch/9873159/
> >>>
> >>> so are there any objections or concerns?
> >>
> >> Not from my side,
> >>
> >> Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> >
> > OK, thanks!
> >
> > I'm going to route it through the PM tree then if that's not a problem.
> 
> Mario, are you okay with this change?
> 

Thanks for checking.  I spent a little time this morning trying to walk through
the ASL as attached to the Bugzilla entry and I think this is the correct approach.

Acked-By: Mario Limonciello <mario.limonciello@dell.com>

Jérôme,
I have one question though.  These events should be happening as a pair.
Press: 0xCE, Release: 0xCF.
What happens with the event on power button release?
Is that showing a message in the log during wakeup from S2I?

Something like "unknown event 0xCF"?
If so, it would be good to also catch and ignore that too.

Thanks,