Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752122AbdHASJ1 (ORCPT ); Tue, 1 Aug 2017 14:09:27 -0400 Received: from ale.deltatee.com ([207.54.116.67]:33256 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752019AbdHASJY (ORCPT ); Tue, 1 Aug 2017 14:09:24 -0400 To: Jon Mason Cc: linux-ntb@googlegroups.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Jiang , Allen Hubbe , Bjorn Helgaas , Greg Kroah-Hartman , Kurt Schwemmer , Stephen Bates , Serge Semin References: <20170725205753.4735-1-logang@deltatee.com> <20170725205753.4735-6-logang@deltatee.com> <20170801180731.GC4186@kudzu.us> From: Logan Gunthorpe Message-ID: <46065aa6-0fe8-59d5-63dc-3beb66b69154@deltatee.com> Date: Tue, 1 Aug 2017 12:09:18 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170801180731.GC4186@kudzu.us> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: fancer.lancer@gmail.com, sbates@raithlin.com, kurt.schwemmer@microsemi.com, gregkh@linuxfoundation.org, bhelgaas@google.com, Allen.Hubbe@emc.com, dave.jiang@intel.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-ntb@googlegroups.com, jdmason@kudzu.us X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v3 05/16] ntb: ntb_test: ensure the link is up before trying to configure the mws X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 822 Lines: 23 On 01/08/17 12:07 PM, Jon Mason wrote: > On Tue, Jul 25, 2017 at 02:57:42PM -0600, Logan Gunthorpe wrote: >> After the link tests, there is a race on one side of the test for >> the link coming up. It's possible, in some cases, for the test script >> to write to the 'peer_trans' files before the link has come up. >> >> To fix this, we simply use the link event file to ensure both sides >> see the link as up before continuning. >> >> Signed-off-by: Logan Gunthorpe > > This looks like a bug fix. Assuming this is the case, I can pull it > out, add a "Fixes" line, and add it to my bug fixes branch. Is this > the case? Sure, yup, if you'd like to do that I'm fine with it. Technically, I don't think the bug can be triggered until the patches later in the series are applied. Thanks, Logan