Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752096AbdHASRy (ORCPT ); Tue, 1 Aug 2017 14:17:54 -0400 Received: from ale.deltatee.com ([207.54.116.67]:33292 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751952AbdHASRx (ORCPT ); Tue, 1 Aug 2017 14:17:53 -0400 To: Jon Mason Cc: linux-ntb@googlegroups.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Jiang , Allen Hubbe , Bjorn Helgaas , Greg Kroah-Hartman , Kurt Schwemmer , Stephen Bates , Serge Semin References: <20170725205753.4735-1-logang@deltatee.com> <20170725205753.4735-7-logang@deltatee.com> <20170801181452.GE4186@kudzu.us> From: Logan Gunthorpe Message-ID: Date: Tue, 1 Aug 2017 12:17:47 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170801181452.GE4186@kudzu.us> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: fancer.lancer@gmail.com, sbates@raithlin.com, kurt.schwemmer@microsemi.com, gregkh@linuxfoundation.org, bhelgaas@google.com, Allen.Hubbe@emc.com, dave.jiang@intel.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-ntb@googlegroups.com, jdmason@kudzu.us X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v3 06/16] ntb: ensure ntb_mw_get_align() is only called when the link is up X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 499 Lines: 15 Hey, On 01/08/17 12:14 PM, Jon Mason wrote: > This also looks like a bug fix. However, given that it is a little more > invasive and no one reporting any problems with it, I'm less apt to > pull it into the bug-fixes branch without anyone compilaining of a > bug (lest I break something in -stable). Yes, 6 and 7 change a semantic of that function. I wouldn't call them bug fixes. But you can't pull 7 without pulling 6, as 7 would break everything unless the change in 6 occurs. Thanks, Logan