Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752129AbdHAT3Z (ORCPT ); Tue, 1 Aug 2017 15:29:25 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:33336 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751987AbdHAT3X (ORCPT ); Tue, 1 Aug 2017 15:29:23 -0400 Date: Tue, 1 Aug 2017 13:29:07 -0600 From: Jason Gunthorpe To: Logan Gunthorpe Cc: Matan Barak , Matan Barak , Yishai Hadas , Doug Ledford , "linux-rdma@vger.kernel.org" , Sean Hefty , Hal Rosenstock , Stephen Bates , "linux-kernel@vger.kernel.org" , Potnuri Bharat Teja Subject: Re: BUG: NULL pointer dereference at ib_uverbs_comp_handler+0x20 Message-ID: <20170801192907.GB31205@obsidianresearch.com> References: <216b770e-fc08-68a6-c1bf-be96d52e325e@deltatee.com> <5866fa2e-d3d9-cdaf-bcb4-806f938aef83@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5866fa2e-d3d9-cdaf-bcb4-806f938aef83@deltatee.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 701 Lines: 19 On Tue, Aug 01, 2017 at 12:32:57PM -0600, Logan Gunthorpe wrote: > Couldn't create rdma QP - Invalid argument > Unable to create QP. > Failed to create QP. Failing to create a QP makes me wonder if you have have this patch? Subject: [PATCH v2 1/2] RDMA/uverbs: Fix the check for port number The port number is only valid if IB_QP_PORT is set in the mask. So only check port number if it is valid to prevent modify_qp from failing due to an invalid port number. Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds") Cc: # v2.6.14+ Reviewed-by: Steve Wise Signed-off-by: Mustafa Ismail Jason