Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752212AbdHATkP (ORCPT ); Tue, 1 Aug 2017 15:40:15 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:40186 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752020AbdHATkM (ORCPT ); Tue, 1 Aug 2017 15:40:12 -0400 Subject: Re: [PATCH 2/2] gpio: omap : Add missing clk_unprepare(). To: Arvind Yadav , , , CC: , , References: From: Grygorii Strashko Message-ID: <6a5f3a21-c69f-1437-85fb-bd5fafc07f52@ti.com> Date: Tue, 1 Aug 2017 14:40:07 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.59.147] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 750 Lines: 30 On 08/01/2017 01:44 AM, Arvind Yadav wrote: > omap_gpio_probe() can fail here and we must disable clock. > > Signed-off-by: Arvind Yadav > --- > drivers/gpio/gpio-omap.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c > index f8c550de..dbf869f 100644 > --- a/drivers/gpio/gpio-omap.c > +++ b/drivers/gpio/gpio-omap.c > @@ -1247,6 +1247,8 @@ static int omap_gpio_probe(struct platform_device *pdev) > if (ret) { > pm_runtime_put_sync(dev); > pm_runtime_disable(dev); > + if (bank->dbck_flag) > + clk_unprepare(bank->dbck); > return ret; > } > > Reviewed-by: Grygorii Strashko -- regards, -grygorii