Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752535AbdHAULO (ORCPT ); Tue, 1 Aug 2017 16:11:14 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:42992 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752100AbdHAULM (ORCPT ); Tue, 1 Aug 2017 16:11:12 -0400 From: Vivien Didelot To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 10/11] net: dsa: mv88e6xxx: remove EEE support In-Reply-To: <87h8xrfdrp.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> References: <20170731221719.16695-1-vivien.didelot@savoirfairelinux.com> <20170731221719.16695-11-vivien.didelot@savoirfairelinux.com> <20170801142843.GE23157@lunn.ch> <87r2wv2tci.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> <20170801160628.GJ23157@lunn.ch> <87h8xrfdrp.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> Date: Tue, 01 Aug 2017 16:08:15 -0400 Message-ID: <87d18fkq4w.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 463 Lines: 15 Vivien Didelot writes: > Second option is: we keep it KISS and let the driver define its noop, > but as I explain, it is confusing, especially for the get operation. In fact we should be good because the DSA layer will call ds->ops->{g,s}et_mac_eee before phy_ethtool_{g,s}et_eee, so if the DSA driver didn't touch the ethtool_eee structure, the PHY ops will anyway. I'm sending a v2 right away. Thanks, Vivien