Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752332AbdHAU3A (ORCPT ); Tue, 1 Aug 2017 16:29:00 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:39225 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752274AbdHAU27 (ORCPT ); Tue, 1 Aug 2017 16:28:59 -0400 Date: Tue, 1 Aug 2017 23:28:37 +0300 From: Dan Carpenter To: Ashish Kalra Cc: gregkh@linuxfoundation.org, wsa@the-dreams.de, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, joe@perches.com Subject: Re: [PATCH] staging: ks7010: fix styling WARNINGs Message-ID: <20170801202837.x4cnpu5rr7yt7vfu@mwanda> References: <1501470921-1947-1-git-send-email-eashishkalra@gmail.com> <1501603889-1988-1-git-send-email-eashishkalra@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501603889-1988-1-git-send-email-eashishkalra@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 337 Lines: 12 The subject is too vague and you need a changelog. On Tue, Aug 01, 2017 at 05:11:29PM +0100, Ashish Kalra wrote: > +static int inc_txqhead(struct ks_wlan_private *priv) > +{ > + priv->tx_dev.qhead = (priv->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE; > + return 0; Just make these void if no one checks the return. regards, dan carpenter