Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752345AbdHAUep (ORCPT ); Tue, 1 Aug 2017 16:34:45 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:47664 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752176AbdHAUeo (ORCPT ); Tue, 1 Aug 2017 16:34:44 -0400 Date: Tue, 1 Aug 2017 22:34:38 +0200 (CEST) From: Thomas Gleixner To: Vikas Shivappa cc: vikas.shivappa@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, peterz@infradead.org, ravi.v.shankar@intel.com, tony.luck@intel.com, fenghua.yu@intel.com, eranian@google.com, davidcc@google.com, ak@linux.intel.com, reinette.chatre@intel.com Subject: Re: [PATCH 10/28] x86/intel_rdt: Simplify info and base file lists In-Reply-To: <1501017287-28083-11-git-send-email-vikas.shivappa@linux.intel.com> Message-ID: References: <1501017287-28083-1-git-send-email-vikas.shivappa@linux.intel.com> <1501017287-28083-11-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 559 Lines: 20 On Tue, 25 Jul 2017, Vikas Shivappa wrote: > for_each_alloc_enabled_rdt_resource(r) { > - kn_subdir = kernfs_create_dir(kn_info, r->name, > - kn_info->mode, r); > - if (IS_ERR(kn_subdir)) { > - ret = PTR_ERR(kn_subdir); > - goto out_destroy; > - } > - kernfs_get(kn_subdir); > - ret = rdtgroup_kn_set_ugid(kn_subdir); > - if (ret) > + fflags = r->fflags | RF_CTRL_INFO; > + if (rdtgroup_mkdir_info_resdir(r, r->name, fflags)) > goto out_destroy; This returns uninitialized ret. Compiler warnins are overrated.... Thanks, tglx