Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752471AbdHAVA7 (ORCPT ); Tue, 1 Aug 2017 17:00:59 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:48249 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752201AbdHAVA6 (ORCPT ); Tue, 1 Aug 2017 17:00:58 -0400 Date: Tue, 1 Aug 2017 23:00:53 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , John Crispin Subject: Re: [PATCH net-next v2 01/11] net: dsa: PHY device is mandatory for EEE Message-ID: <20170801210053.GN23157@lunn.ch> References: <20170801203241.22294-1-vivien.didelot@savoirfairelinux.com> <20170801203241.22294-2-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170801203241.22294-2-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 412 Lines: 10 On Tue, Aug 01, 2017 at 04:32:31PM -0400, Vivien Didelot wrote: > The port's PHY and MAC are both implied in EEE. The current code does > not call the PHY operations if the related device is NULL. Change that > by returning -ENODEV if there's no PHY device attached to the interface. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew