Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752403AbdHAVDP (ORCPT ); Tue, 1 Aug 2017 17:03:15 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:48255 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751938AbdHAVDO (ORCPT ); Tue, 1 Aug 2017 17:03:14 -0400 Date: Tue, 1 Aug 2017 23:03:12 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , John Crispin Subject: Re: [PATCH net-next v2 07/11] net: dsa: mv88e6xxx: call phy_init_eee Message-ID: <20170801210312.GO23157@lunn.ch> References: <20170801203241.22294-1-vivien.didelot@savoirfairelinux.com> <20170801203241.22294-8-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170801203241.22294-8-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 375 Lines: 10 On Tue, Aug 01, 2017 at 04:32:37PM -0400, Vivien Didelot wrote: > It is safer to init the EEE before the DSA layer call > phy_ethtool_set_eee, as sf2 and qca8k are doing. I can understand making all the drivers do the same thing, but the next patch deletes this change, making is pointless. My preference would be to drop this. But it is not a strong preference. Andrew