Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752844AbdHAVG3 (ORCPT ); Tue, 1 Aug 2017 17:06:29 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:48267 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752365AbdHAVG2 (ORCPT ); Tue, 1 Aug 2017 17:06:28 -0400 Date: Tue, 1 Aug 2017 23:06:26 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , John Crispin Subject: Re: [PATCH net-next v2 09/11] net: dsa: remove PHY device argument from .set_eee Message-ID: <20170801210626.GQ23157@lunn.ch> References: <20170801203241.22294-1-vivien.didelot@savoirfairelinux.com> <20170801203241.22294-10-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170801203241.22294-10-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 499 Lines: 13 On Tue, Aug 01, 2017 at 04:32:39PM -0400, Vivien Didelot wrote: > The DSA switch operations for EEE are only meant to configure a port's > MAC EEE settings. The port's PHY EEE settings are accessed by the DSA > layer and must be made available via a proper PHY driver. > > In order to reduce this confusion, remove the phy_device argument from > the .set_eee operation. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew