Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752807AbdHAVbF (ORCPT ); Tue, 1 Aug 2017 17:31:05 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:37217 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546AbdHAVbC (ORCPT ); Tue, 1 Aug 2017 17:31:02 -0400 Subject: Re: [PATCH net-next v2 01/11] net: dsa: PHY device is mandatory for EEE To: Vivien Didelot , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn , John Crispin References: <20170801203241.22294-1-vivien.didelot@savoirfairelinux.com> <20170801203241.22294-2-vivien.didelot@savoirfairelinux.com> From: Florian Fainelli Message-ID: <1e4a5f28-4673-8eda-96ab-fffa02d4d4e7@gmail.com> Date: Tue, 1 Aug 2017 14:31:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170801203241.22294-2-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 405 Lines: 10 On 08/01/2017 01:32 PM, Vivien Didelot wrote: > The port's PHY and MAC are both implied in EEE. The current code does > not call the PHY operations if the related device is NULL. Change that > by returning -ENODEV if there's no PHY device attached to the interface. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian