Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751631AbdHAW6u (ORCPT ); Tue, 1 Aug 2017 18:58:50 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:34667 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750986AbdHAW6s (ORCPT ); Tue, 1 Aug 2017 18:58:48 -0400 MIME-Version: 1.0 In-Reply-To: <1500894086.20057.12.camel@intel.com> References: <20170721145147.7572-1-jprvita@endlessm.com> <1500894086.20057.12.camel@intel.com> From: =?UTF-8?Q?Jo=C3=A3o_Paulo_Rechi_Vita?= Date: Tue, 1 Aug 2017 15:58:47 -0700 Message-ID: Subject: Re: [PATCH] iwlwifi: Demote messages about fw flags size to info To: "Coelho, Luciano" Cc: linuxwifi , "kvalo@codeaurora.org" , "jprvita@gmail.com" , "Berg, Johannes" , "Grumbach, Emmanuel" , "linux-wireless@vger.kernel.org" , "linux@endlessm.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v71MwufV003219 Content-Length: 1216 Lines: 34 Hello Luca, On Mon, Jul 24, 2017 at 4:01 AM, Coelho, Luciano wrote: > On Fri, 2017-07-21 at 07:51 -0700, João Paulo Rechi Vita wrote: (...) >> Currently these messages are presented to the user during boot if there >> is no bootsplash covering the console, sometimes even if the boot splash >> is enabled but has not started yet by the time this message is shown. >> I should have provided another piece of information here: all of this happens even when booting with the 'quiet' kernel parameter. > This specific case is harmless, but I'd rather keep this message as an > error, because in other situations it could lead to unexpected > behavioir, so I prefer to keep it very visible. > > I see your point, and I understand the purpose of these messages. I'm wondering if perhaps having them at the warning level would give them enough visibility, while still keeping a clean boot process to the end user. If so, I can send an updated patch. Thanks for your reply and for pointing to the fix for the root cause of that message. Cheers, ...................................................................................... João Paulo Rechi Vita | +1.415.851.5778 | Endless